Skip to content

Conversation

@tchaton
Copy link
Collaborator

@tchaton tchaton commented Jan 14, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

This PR properly add support for s3_folders. Unfortunately, the files were evicted and deleted.

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78%. Comparing base (1eaa79f) to head (c513f0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #450   +/-   ##
===================================
- Coverage    79%    78%   -0%     
===================================
  Files        35     35           
  Lines      5118   5123    +5     
===================================
- Hits       4020   4019    -1     
- Misses     1098   1104    +6     

@tchaton tchaton merged commit 08bf77d into main Jan 14, 2025
29 checks passed
@tchaton tchaton deleted the add_support_for_s3_folders branch January 14, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant