Skip to content

Conversation

@bhimrazy
Copy link
Collaborator

@bhimrazy bhimrazy commented Dec 2, 2025

What does this PR do?

Fixes failing test_evaluate.py::test_evaluate_script test on master by pinning lm-eval<0.4.9.1.

ref: ci : https://github.com/Lightning-AI/litgpt/actions/runs/19823757338/job/56877042404?pr=2164

Also unblocks other prs

FAILED tests/test_evaluate.py::test_evaluate_script - ValueError: The repository for EleutherAI/logiqa contains custom code which must be executed to correctly load the dataset. You can inspect the repository content at https://hf.co/datasets/EleutherAI/logiqa.
Please pass the argument `trust_remote_code=True` to allow custom code to be run.

ref: #2102 (previously pin was added here)

Some lm-eval task datasets (e.g. EleutherAI/logiqa) require trust_remote_code=True
which newer versions don't handle properly.

See: EleutherAI/lm-evaluation-harness#3171
Related: #2102
Copy link
Collaborator

@lianakoleva lianakoleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree < is better than != but we should eventually use trust_remote_code where needed to be compatible with newer versions as well.

@lianakoleva lianakoleva merged commit 299cfa4 into main Dec 4, 2025
44 of 60 checks passed
@lianakoleva lianakoleva deleted the fix/pin-lm-eval-trust-remote-code branch December 4, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants