Skip to content

Improve legacy checkpoint testing #5491

@carmocca

Description

@carmocca

🚀 Feature

Improve legacy checkpoint testing

Motivation

Currently, we only test whether a legacy checkpoint can be loaded and run, but no internal state is checked.

Pitch

Check the epoch number is correct, if the state is the expected, if we achieve a particular loss after 1 step...

We already have similar tests, we just have to do them for legacy checkpoints. see

https://github.com/PyTorchLightning/pytorch-lightning/blob/master/tests/models/test_restore.py

Additional context

https://github.com/PyTorchLightning/pytorch-lightning/blob/1f6236accce78303249c55de656b71501e607d1a/tests/checkpointing/test_legacy_checkpoints.py#L49-L72

cc: @Borda

Metadata

Metadata

Assignees

Labels

checkpointingRelated to checkpointingciContinuous Integrationhelp wantedOpen to be worked onpriority: 0High priority task

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions