Skip to content

Legacy: simple classif training #8535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Aug 10, 2021
Merged

Legacy: simple classif training #8535

merged 18 commits into from
Aug 10, 2021

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 23, 2021 •
edited
Loading

What does this PR do?

Resolves #5491

Does your PR introduce any breaking changes ? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)
  • Did you list all the breaking changes introduced by this pull request?

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the ci Continuous Integration label Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021 •
edited
Loading

Codecov Report

Merging #8535 (470c019) into master (a7d207c) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #8535   +/-   ##
======================================
  Coverage      93%     93%           
======================================
  Files         169     169           
  Lines       14069   14069           
======================================
  Hits        13041   13041           
  Misses       1028    1028

@Borda Borda added this to the v1.4.x milestone Jul 23, 2021
@Borda Borda marked this pull request as ready for review July 23, 2021 11:07
Borda
Borda commented Jul 23, 2021
View reviewed changes
@Borda
Copy link
Collaborator Author

Borda commented Jul 23, 2021

new generated for local testing... checkpoints.zip

carmocca
carmocca reviewed Jul 23, 2021
View reviewed changes
Borda
Borda commented Jul 23, 2021
View reviewed changes
@Borda Borda requested a review from carmocca July 23, 2021 13:21
@Borda Borda changed the title [RFC] Legacy: simple classif training Legacy: simple classif training Jul 23, 2021
tchaton
tchaton reviewed Jul 26, 2021
View reviewed changes
carmocca
carmocca reviewed Jul 26, 2021
View reviewed changes
@mergify mergify bot removed the has conflicts label Jul 26, 2021
@Borda Borda requested review from carmocca and tchaton July 26, 2021 14:03
awaelchli
awaelchli approved these changes Jul 29, 2021
View reviewed changes
Borda
Borda commented Jul 29, 2021
View reviewed changes
tchaton
tchaton reviewed Aug 2, 2021
View reviewed changes
tchaton
tchaton approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2021
Borda and others added 12 commits August 10, 2021 08:52
@Borda Borda mentioned this pull request Aug 10, 2021
Closed
@Borda Borda enabled auto-merge (squash) August 10, 2021 07:40
@Borda Borda merged commit 0778ffb into master Aug 10, 2021
@Borda Borda deleted the ci/legacy branch August 10, 2021 08:13
SeanNaren pushed a commit that referenced this pull request Aug 10, 2021
@Borda
Legacy: simple classif training (#8535)
70bd40c 
* simple_classif_training
* fix test
* pt1.6
* automate

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>

(cherry picked from commit 0778ffb)
lexierule pushed a commit that referenced this pull request Aug 11, 2021
@Borda @lexierule
Legacy: simple classif training (#8535)
7cc4cc5 
* simple_classif_training
* fix test
* pt1.6
* automate

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>

(cherry picked from commit 0778ffb)
four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
@Borda @carmocca
@pre-commit-ci @awaelchli @tchaton @four4fish
Legacy: simple classif training (Lightning-AI#8535)
c5255e5 
* simple_classif_training
* fix test
* pt1.6
* automate

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: thomas chaton <thomas@grid.ai>
@akihironitta akihironitta mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@carmocca carmocca Awaiting requested review from carmocca

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.4.x

Development

Successfully merging this pull request may close these issues.

Improve legacy checkpoint testing

5 participants

@Borda @awaelchli @carmocca @tchaton @kaushikb11