Skip to content

Override optimizer_zero_grad when using the IPUStrategy #12913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 1, 2022
Merged

Override optimizer_zero_grad when using the IPUStrategy #12913

merged 14 commits into from
May 1, 2022

Conversation

@hmellor
Copy link
Contributor

@hmellor hmellor commented Apr 28, 2022

What does this PR do?

Overrides the optimizer_zero_grad function to do nothing when IPUStrategy is used. This is because this operation is handled internally by the IPU.

Fixes #12903

Does your PR introduce any breaking changes? If yes, please list them.

None.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

SeanNaren
SeanNaren reviewed Apr 28, 2022
View reviewed changes
@SeanNaren SeanNaren added the accelerator: ipu (removed) Intelligence Processing Unit label Apr 28, 2022
@SeanNaren SeanNaren added this to the 1.6.x milestone Apr 28, 2022
@SeanNaren
Copy link
Contributor

SeanNaren commented Apr 28, 2022

Great first PR @hmellor was awesome working with you on this :)

@hmellor
Specify return type for _disable_zero_grad
b986c3f 
Co-authored-by: Sean Naren <sean@grid.ai>
@mergify mergify bot added the ready PRs ready to be merged label Apr 28, 2022
carmocca
carmocca approved these changes Apr 28, 2022
View reviewed changes
@carmocca carmocca added the community This PR is from the community label Apr 28, 2022
rohitgr7
rohitgr7 reviewed Apr 28, 2022
View reviewed changes
@carmocca @rohitgr7
Update CHANGELOG.md
491bbdb 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
ananthsub
ananthsub reviewed Apr 28, 2022
View reviewed changes
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Apr 28, 2022
@mergify mergify bot added ready PRs ready to be merged has conflicts and removed has conflicts ready PRs ready to be merged labels Apr 28, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Apr 29, 2022
carmocca
carmocca reviewed Apr 29, 2022
View reviewed changes
@carmocca carmocca enabled auto-merge (squash) April 29, 2022 16:34
@carmocca carmocca merged commit 62c7390 into Lightning-AI:master May 1, 2022
carmocca added a commit that referenced this pull request May 2, 2022
@hmellor @carmocca @rohitgr7
Override optimizer_zero_grad when using the IPUStrategy (#12913)
423338c 
Co-authored-by: Sean Naren <sean@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
carmocca added a commit that referenced this pull request May 3, 2022
@hmellor @carmocca @rohitgr7
Override optimizer_zero_grad when using the IPUStrategy (#12913)
0bd7521 
Co-authored-by: Sean Naren <sean@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
lexierule pushed a commit that referenced this pull request May 3, 2022
@hmellor @carmocca
@rohitgr7 @lexierule
Override optimizer_zero_grad when using the IPUStrategy (#12913)
30a3e5d 
Co-authored-by: Sean Naren <sean@grid.ai>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda

6 more reviewers

@ananthsub ananthsub ananthsub left review comments

@awaelchli awaelchli awaelchli approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hmellor hmellor

Labels

accelerator: ipu (removed) Intelligence Processing Unit community This PR is from the community ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.6.x

Development

Successfully merging this pull request may close these issues.

Additional zero_grad and backward being performed when using IPU

7 participants

@hmellor @SeanNaren @ananthsub @awaelchli @carmocca @rohitgr7 @kaushikb11