Skip to content

Conversation

@otaj
Copy link
Contributor

@otaj otaj commented Aug 22, 2022

What does this PR do?

Bump CUDA in Docker images to 11.6.1 in order to have more recent NCCL version

Fixes #14347 and #14346

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda

@Borda Borda changed the title [CI] Bump CUDA in Docker images to 11.6.1 in order to have more recent NCCL version [CI] Bump CUDA in Docker images to 11.6.1 Aug 22, 2022
@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Aug 22, 2022
@Borda Borda added this to the all:next milestone Aug 22, 2022
@otaj otaj changed the title [CI] Bump CUDA in Docker images to 11.6.1 [CI] Bump CUDA in Docker images to 11.5.1 Aug 23, 2022
@otaj otaj changed the title [CI] Bump CUDA in Docker images to 11.5.1 [CI] Bump CUDA in Docker images to 11.6.1 Aug 23, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you Ota!

@mergify mergify bot added the ready PRs ready to be merged label Aug 23, 2022
@Borda Borda requested a review from carmocca August 23, 2022 15:18
@Borda Borda enabled auto-merge (squash) August 23, 2022 15:18
@carmocca carmocca disabled auto-merge August 23, 2022 16:10
@lexierule lexierule merged commit bb63431 into master Aug 23, 2022
@lexierule lexierule deleted the ci/bump_docker_version branch August 23, 2022 16:10
rohitgr7 pushed a commit that referenced this pull request Aug 23, 2022
* bump cuda in docker images to 11.6.1

* PUSH TO HUB. REVERT THIS!

* conda forge for 11.6

* cuda 11.5

* revert conda changes

* 11.6 back again

* 11.6 back again, all of them

* maybe all passes now

* maybe all passes now

* final push

* Revert "PUSH TO HUB. REVERT THIS!"

This reverts commit 602bfce.

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
nicolai86 pushed a commit that referenced this pull request Aug 23, 2022
* bump cuda in docker images to 11.6.1

* PUSH TO HUB. REVERT THIS!

* conda forge for 11.6

* cuda 11.5

* revert conda changes

* 11.6 back again

* 11.6 back again, all of them

* maybe all passes now

* maybe all passes now

* final push

* Revert "PUSH TO HUB. REVERT THIS!"

This reverts commit 602bfce.

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@otaj otaj mentioned this pull request Aug 24, 2022
lexierule pushed a commit that referenced this pull request Aug 25, 2022
* bump cuda in docker images to 11.6.1

* PUSH TO HUB. REVERT THIS!

* conda forge for 11.6

* cuda 11.5

* revert conda changes

* 11.6 back again

* 11.6 back again, all of them

* maybe all passes now

* maybe all passes now

* final push

* Revert "PUSH TO HUB. REVERT THIS!"

This reverts commit 602bfce.

* Apply suggestions from code review

Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Failing (flaky?) test in GPU CI

7 participants