Skip to content

Conversation

@wangraying
Copy link
Contributor

@wangraying wangraying commented Sep 4, 2022

What does this PR do?

Fixes #14347 and #14346, remove special handings for bagua in #14348 and #14380

Does your PR introduce any breaking changes? If yes, please list them.

No

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@wangraying wangraying changed the title Add support for bagua-cuda116 Add bagua support for CUDA 11.6 images Sep 4, 2022
@carmocca carmocca added the ci Continuous Integration label Sep 4, 2022
@carmocca carmocca added this to the pl:1.7.x milestone Sep 4, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 4, 2022
@akihironitta akihironitta enabled auto-merge (squash) September 4, 2022 17:06
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@otaj can you look? I remember you made some updates before due to the ci failures.

@akihironitta akihironitta merged commit 40868f7 into Lightning-AI:master Sep 9, 2022
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
* Add support for bagua-cuda116

* Remove bagua-cuda115 from installation

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
* Add support for bagua-cuda116

* Remove bagua-cuda115 from installation

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
* Add support for bagua-cuda116

* Remove bagua-cuda115 from installation

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
lexierule pushed a commit that referenced this pull request Sep 13, 2022
* Add support for bagua-cuda116

* Remove bagua-cuda115 from installation

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
@Borda
Copy link
Collaborator

Borda commented Oct 31, 2022

@wangraying are you supporting the new PT 1.13?

@wangraying
Copy link
Contributor Author

Thanks for your reminding, Borda. We will support PT 1.13. cc @woqidaideshi

@Borda
Copy link
Collaborator

Borda commented Nov 7, 2022

Thanks for your reminding, Borda. We will support PT 1.13. cc @woqidaideshi

hi, how is it going, any ETA? 🦦

@wangraying
Copy link
Contributor Author

Thanks for your reminding, Borda. We will support PT 1.13. cc @woqidaideshi

hi, how is it going, any ETA? 🦦

Within this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged strategy: bagua (removed) Bagua

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing (flaky?) test in GPU CI

6 participants