-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix neptune-client package available detection #14714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borda
approved these changes
Sep 15, 2022
990eac4 to
5095700
Compare
carmocca
approved these changes
Sep 16, 2022
37ca735 to
7c244a7
Compare
Contributor
Author
|
Quick notice:
Is it ok if we rebase-merge it like this? Or do you have a different preference? |
Contributor
|
It is okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
logger: neptune
pl
Generic label for PyTorch Lightning package
priority: 0
High priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14695
This targets the release/pytorch branch!
Discussed with @carmocca that my immediate fix can directly go to the release branch for the next patch. Note that we don't have the lightning-utilities dependency for this branch.
Meanwhile, @carmocca will push the proper fix to master in #14715 and follow up.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @tchaton @rohitgr7 @Blaizzy @akihironitta