Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Sep 15, 2022

What does this PR do?

Fixes #14695

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda @Blaizzy @akihironitta

@carmocca carmocca added this to the pl:1.8 milestone Sep 15, 2022
@carmocca carmocca self-assigned this Sep 15, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 15, 2022
@mergify mergify bot removed the has conflicts label Sep 16, 2022
@carmocca carmocca enabled auto-merge (squash) September 16, 2022 17:49
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@krshrimali krshrimali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@mergify mergify bot added the ready PRs ready to be merged label Sep 19, 2022
@krshrimali
Copy link
Contributor

@carmocca, do you want the milestone to be pl:1.7.x? (if we are doing a patch release tomorrow)

@carmocca
Copy link
Contributor Author

@krshrimali No. This is only relevant to the 1.8 branch, but thank you for asking!

@carmocca carmocca merged commit 810643b into master Sep 20, 2022
@carmocca carmocca deleted the neptune/installation branch September 20, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code quality logger: neptune pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Unable to use neptune logger after a version upgrade of pytorch lightning

3 participants