Skip to content

Adding test for legacy checkpoint created with 2.0.2 #15946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Adding test for legacy checkpoint created with 2.0.2 #15946

wants to merge 3 commits into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2022 •
edited
Loading

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot added pl Generic label for PyTorch Lightning package tests labels Dec 7, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 60a1656 to 6afd573 Compare December 8, 2022 18:55
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Dec 9, 2022
@Borda Borda requested a review from a team December 9, 2022 11:12
@github-actions
Copy link
Contributor Author

github-actions bot commented Dec 9, 2022 •
edited
Loading

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) failure ❌
pl-cpu (macOS-11, lightning, 3.9, 1.12) failure ❌
pl-cpu (macOS-11, lightning, 3.10, 1.13) failure ❌
pl-cpu (macOS-11, lightning, 3.10, 2.0) failure ❌
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) failure ❌
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) failure ❌
pl-cpu (windows-2022, lightning, 3.8, 1.11) failure ❌
pl-cpu (windows-2022, lightning, 3.9, 1.12) failure ❌
pl-cpu (windows-2022, lightning, 3.10, 1.13) failure ❌
pl-cpu (windows-2022, lightning, 3.10, 2.0) failure ❌
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) failure ❌
pl-cpu (macOS-11, pytorch, 3.8, 1.13) failure ❌
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) failure ❌
pl-cpu (windows-2022, pytorch, 3.8, 1.13) failure ❌

These checks are required after the changes to tests/legacy/back-compatible-versions.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda enabled auto-merge (squash) December 9, 2022 11:12
@awaelchli
Copy link
Contributor

awaelchli commented Dec 9, 2022

@github-actions you have a typo in the title: checkpiont -> checkpoint

akihironitta
akihironitta approved these changes Dec 9, 2022
View reviewed changes
@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2022
@github-actions github-actions bot changed the title Adding test for legacy checkpiont created with 1.8.4 Adding test for legacy checkpiont created with 1.8.4.post0 Dec 9, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 5b371b7 to 9ca3776 Compare December 9, 2022 23:47
@github-actions github-actions bot added pl Generic label for PyTorch Lightning package and removed pl Generic label for PyTorch Lightning package labels Dec 9, 2022
@awaelchli awaelchli mentioned this pull request Dec 10, 2022
Merged
11 tasks
akihironitta
akihironitta reviewed Dec 13, 2022
View reviewed changes
@github-actions github-actions bot changed the title Adding test for legacy checkpiont created with 1.8.4.post0 Adding test for legacy checkpoint created with 1.8.5 Dec 15, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from d8257df to 2700678 Compare December 15, 2022 17:23
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Dec 15, 2022
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 1.8.5 Adding test for legacy checkpoint created with 1.8.5.post0 Dec 16, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 2700678 to bc1703a Compare December 16, 2022 14:16
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Dec 20, 2022
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 1.8.5.post0 Adding test for legacy checkpoint created with 1.8.6 Dec 21, 2022
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from ee4eec4 to e4c47ce Compare December 21, 2022 18:39
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 491949a to 745fd20 Compare February 15, 2023 15:27
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 1.9.2 Adding test for legacy checkpoint created with 1.9.3 Feb 21, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 745fd20 to 5a26907 Compare February 21, 2023 20:44
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 1.9.3 Adding test for legacy checkpoint created with 2.0.0rc0 Feb 23, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 5a26907 to 85e9705 Compare February 23, 2023 19:01
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 2.0.0rc0 Adding test for legacy checkpoint created with 1.9.4 Feb 28, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch 3 times, most recently from caafd94 to d73888c Compare March 2, 2023 14:02
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 1.9.4 Adding test for legacy checkpoint created with 2.0.0 Mar 15, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from d73888c to bc9eed0 Compare March 15, 2023 13:02
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 2.0.0 Adding test for legacy checkpoint created with 2.0.1 Mar 30, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from bc9eed0 to b046e54 Compare March 30, 2023 17:11
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 2.0.1 Adding test for legacy checkpoint created with 2.0.1.post0 Apr 11, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from b046e54 to ea53644 Compare April 11, 2023 18:47
@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 2.0.1.post0 Adding test for legacy checkpoint created with 1.9.5 Apr 12, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from ea53644 to cefb1de Compare April 12, 2023 15:35
@Borda Borda marked this pull request as ready for review April 14, 2023 08:35
@Borda Borda requested a review from lantiga as a code owner April 14, 2023 08:35
This was referenced Apr 14, 2023
Merged
Merged
@Borda
Copy link
Collaborator

Borda commented Apr 14, 2023

  • Some checkpoints were not generated & uploaded to S3 during the release CD:

addressing in #17374

@github-actions github-actions bot changed the title Adding test for legacy checkpoint created with 1.9.5 Adding test for legacy checkpoint created with 2.0.2 Apr 24, 2023
@github-actions github-actions bot force-pushed the create-pull-request/patch branch from 0659a52 to fab4a8a Compare April 24, 2023 13:19
@mergify mergify bot added the has conflicts label May 4, 2023
@Borda Borda mentioned this pull request May 4, 2023
Merged
6 tasks
@Borda Borda closed this in #17562 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

+1 more reviewer

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@akihironitta akihironitta

Labels

has conflicts pl Generic label for PyTorch Lightning package release tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awaelchli @akihironitta @Borda