Skip to content

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Feb 6, 2023

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@github-actions github-actions bot added app (removed) Generic label for Lightning App package ci Continuous Integration labels Feb 6, 2023
@justusschock justusschock marked this pull request as ready for review February 6, 2023 15:46
@justusschock justusschock changed the title add integration test tldr WIP: add integration test tldr Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning: Flagships
Check ID Status
test-flagships / run-flagships (flashy, Lightning-Universe/Flashy-app) success

These checks are required after the changes to .github/workflows/_flagship-apps.yml, tests/integrations_app/flagship/test_tldr.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@stale
Copy link

stale bot commented Mar 18, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Mar 18, 2023
@stale
Copy link

stale bot commented Mar 25, 2023

This pull request is going to be closed. Please feel free to reopen it or create a new one based on top of the 'master' branch.

@stale stale bot closed this Mar 25, 2023
@Borda Borda deleted the integration_tests/tldr branch July 26, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ci Continuous Integration won't fix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants