-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Remove implicit frontend testing from testing.run_app_in_cloud
#16741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 lightning_app: Tests workflow
These checks are required after the changes to 🟢 lightning_app: Examples
These checks are required after the changes to 🟢 lightning_app: Azure
These checks are required after the changes to 🟢 lightning_app: Docs
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 installThese checks are required after the changes to 🟢 link-check
These checks are required after the changes to Thank you for your contribution! 💜
|
for more information, see https://pre-commit.ci
This reverts commit 0b53053.
This reverts commit d769232.
for more information, see https://pre-commit.ci
ethanwharris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just blocking until there is more context. Quite unclear why we remove the auth + admin view.
Removing auth: Makes it harder to run e2e on different envs with playwright Chrome browser to check how it goes.
Remove admin view: We lose the recordings on CI failures + this is a breaking change for other app using this hook.
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
testing.run_app_in_cloud
What does this PR do?
This removes implicit frontend testing from run_app_in_cloud (that wasn't valid with recent frontend changes).
Unblocks #16650
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda