fix warning so the user has a clear next step #16751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nohalon merged 5 commits into master from fix_warning

Feb 17, 2023

Contributor

nohalon commented Feb 14, 2023 •

edited by github-actions bot

Loading

tell the user exactly how to install lightning-api-access directly from the warning


          fix warning so the user doesn't have to think about how to install th…

b7ed3f2

…e lightning UI

nohalon requested review from awaelchli, ethanwharris, hhsecond, lantiga and tchaton as code owners

February 14, 2023 14:18

github-actions bot added the app (removed) label

Contributor

github-actions bot commented Feb 14, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (lightning)	success	✅
make-html (lightning)	success	✅

These checks are required after the changes to src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/components/serve/python_server.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.


          fix warning in the autoscaler

a766f9d

tchaton approved these changes

View reviewed changes

Contributor

tchaton left a comment

LGTM !

src/lightning/app/components/serve/auto_scaler.py Outdated Show resolved Hide resolved

awaelchli approved these changes

View reviewed changes

src/lightning/app/components/serve/python_server.py Outdated Show resolved Hide resolved

awaelchli added this to the v1.9.x milestone

mergify bot added the ready label

nohalon commented

View reviewed changes

src/lightning/app/components/serve/auto_scaler.py Outdated Show resolved Hide resolved

nohalon commented

View reviewed changes

src/lightning/app/components/serve/python_server.py Outdated Show resolved Hide resolved

nohalon and others added 3 commits

February 14, 2023 19:13


          Apply suggestions from code review

095905f


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d6d4c28

for more information, see https://pre-commit.ci


          Merge branch 'master' into fix_warning

acc0b56

nohalon merged commit 1a6331f into master

nohalon deleted the fix_warning branch

February 17, 2023 07:26

awaelchli pushed a commit that referenced this pull request


          fix warning so the user has a clear next step (#16751)

lexierule pushed a commit that referenced this pull request


          fix warning so the user has a clear next step (#16751)

b8d74fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tchaton tchaton approved these changes

lantiga Awaiting requested review from lantiga lantiga is a code owner

hhsecond Awaiting requested review from hhsecond

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

+1 more reviewer

awaelchli awaelchli approved these changes

Labels

app (removed) ready