Skip to content

fix warning so the user has a clear next step #16751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2023
Merged

fix warning so the user has a clear next step #16751

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7ed3f2
fix warning so the user doesn't have to think about how to install th…
nohalon Feb 14, 2023
a766f9d
fix warning in the autoscaler
nohalon Feb 14, 2023
095905f
Apply suggestions from code review
nohalon Feb 14, 2023
d6d4c28
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 14, 2023
acc0b56
Merge branch 'master' into fix_warning
nohalon Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lightning/app/components/serve/auto_scaler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,9 @@ def _get_endpoint_info_page(self) -> Optional["APIAccessFrontend"]: # noqa: F82
try:
from lightning_api_access import APIAccessFrontend
except ModuleNotFoundError:
logger.warn("APIAccessFrontend not found. Please install lightning-api-access to enable the UI")
logger.warn(
"Some dependencies to run the UI are missing. To resolve, run `pip install lightning-api-access`"
)
return

if is_running_in_cloud():
Expand Down
4 changes: 3 additions & 1 deletion src/lightning/app/components/serve/python_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,9 @@ def configure_layout(self) -> Optional["Frontend"]:
try:
from lightning_api_access import APIAccessFrontend
except ModuleNotFoundError:
logger.warn("APIAccessFrontend not found. Please install lightning-api-access to enable the UI")
logger.warn(
"Some dependencies to run the UI are missing. To resolve, run `pip install lightning-api-access`"
)
return

class_name = self.__class__.__name__
Expand Down