Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Mar 27, 2023

What does this PR do?

not sure why the CI passed on #17200 and start to fail on master, so maybe the cache is unique per workflow? 🤔 but still it shall crash on CI :/

UPDATE: it was the dam pull_request_target 😵‍💫

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @tchaton @carmocca @akihironitta @Borda

@Borda Borda added bug Something isn't working priority: 0 High priority task ci Continuous Integration labels Mar 27, 2023
@Borda Borda added this to the 2.0.x milestone Mar 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 27, 2023

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success
pl-cpu (macOS-11, lightning, 3.9, 1.12) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
pl-cpu (windows-2022, lightning, 3.8, 1.11) success
pl-cpu (windows-2022, lightning, 3.9, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml.

🔴 fabric: Docs
Check ID Status
make-doctest (fabric) failure
make-html (fabric) failure

These checks are required after the changes to .github/workflows/docs-build.yml.

🔴 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) failure
make-html (pytorch) failure

These checks are required after the changes to .github/workflows/docs-build.yml.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success

These checks are required after the changes to .github/workflows/ci-tests-fabric.yml.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success
app-pytest (macOS-11, lightning, 3.8, oldest) success
app-pytest (macOS-11, app, 3.9, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success
app-pytest (ubuntu-20.04, app, 3.9, latest) success
app-pytest (windows-2022, lightning, 3.8, latest) success
app-pytest (windows-2022, lightning, 3.8, oldest) success
app-pytest (windows-2022, app, 3.8, latest) success

These checks are required after the changes to .github/workflows/ci-tests-app.yml.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (macOS-11, lightning, 3.9, oldest) success
app-examples (macOS-11, app, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, oldest) success
app-examples (windows-2022, app, 3.9, latest) success

These checks are required after the changes to .github/workflows/ci-examples-app.yml.

🔴 lightning_app: Docs
Check ID Status
make-doctest (app) failure
make-html (app) failure

These checks are required after the changes to .github/workflows/docs-build.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested review from a team and awaelchli March 27, 2023 11:19
@Borda Borda marked this pull request as draft March 27, 2023 11:20
@Borda
Copy link
Collaborator Author

Borda commented Mar 27, 2023

see the run: https://github.com/Lightning-AI/lightning/actions/runs/4531837290/jobs/7982469731?pr=17201

will need a force merge... 🙏

@Borda Borda marked this pull request as ready for review March 27, 2023 11:33
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #17201 (42a4fa8) into master (be69880) will increase coverage by 13%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #17201     +/-   ##
=========================================
+ Coverage      69%      82%    +13%     
=========================================
  Files         433      413     -20     
  Lines       31560    31356    -204     
=========================================
+ Hits        21625    25672   +4047     
+ Misses       9935     5684   -4251     

@Borda Borda changed the title ci: wheel from cache ci/docs: wheels from cache Mar 27, 2023
@lantiga lantiga merged commit 1284292 into master Mar 27, 2023
@lantiga lantiga deleted the ci/docs_build branch March 27, 2023 14:40
carmocca pushed a commit that referenced this pull request Mar 30, 2023
* ci: wheel from cache

* ci: wheel from cache

* rev
lantiga pushed a commit that referenced this pull request Mar 30, 2023
* ci: wheel from cache

* ci: wheel from cache

* rev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 0 High priority task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants