Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jun 7, 2023

Adds more commits on top of #17459

cc @Borda @carmocca @justusschock @awaelchli

@github-actions github-actions bot added app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package labels Jun 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success
pl-cpu (macOS-11, lightning, 3.9, 1.12) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
pl-cpu (windows-2022, lightning, 3.8, 1.11) success
pl-cpu (windows-2022, lightning, 3.9, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py, src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/utilities/imports.py, tests/tests_pytorch/trainer/connectors/test_callback_connector.py, tests/tests_pytorch/trainer/logging_/test_eval_loop_logging.py.

🟢 fabric: Docs
Check ID Status
make-doctest (fabric) success
make-html (fabric) success

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/utilities/imports.py, docs/source-pytorch/community/governance.rst, docs/source-pytorch/community/index.rst, docs/source-pytorch/glossary/index.rst, docs/source-pytorch/index.rst, docs/source-pytorch/past_versions.rst.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/utilities/test_registry.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
lightning-fabric (GPUs) success

These checks are required after the changes to src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/utilities/test_registry.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success
app-pytest (macOS-11, lightning, 3.8, oldest) success
app-pytest (macOS-11, app, 3.9, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success
app-pytest (ubuntu-20.04, app, 3.9, latest) success
app-pytest (windows-2022, lightning, 3.8, latest) success
app-pytest (windows-2022, lightning, 3.8, oldest) success
app-pytest (windows-2022, app, 3.8, latest) success

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py, tests/tests_app/core/test_lightning_app.py, tests/tests_app/core/test_lightning_flow.py, tests/tests_app/structures/test_structures.py, tests/tests_app/utilities/test_proxies.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (macOS-11, lightning, 3.9, oldest) success
app-examples (macOS-11, app, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, oldest) success
app-examples (windows-2022, app, 3.9, latest) success

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py.

🟢 lightning_app: Docs
Check ID Status
make-doctest (app) success
make-html (app) success

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py, src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/utilities/imports.py, src/version.info.

🟢 install
Check ID Status
install-pkg (ubuntu-22.04, app, 3.8) success
install-pkg (ubuntu-22.04, app, 3.10) success
install-pkg (ubuntu-22.04, fabric, 3.8) success
install-pkg (ubuntu-22.04, fabric, 3.10) success
install-pkg (ubuntu-22.04, pytorch, 3.8) success
install-pkg (ubuntu-22.04, pytorch, 3.10) success
install-pkg (ubuntu-22.04, lightning, 3.8) success
install-pkg (ubuntu-22.04, lightning, 3.10) success
install-pkg (ubuntu-22.04, notset, 3.8) success
install-pkg (ubuntu-22.04, notset, 3.10) success
install-pkg (macOS-12, app, 3.8) success
install-pkg (macOS-12, app, 3.10) success
install-pkg (macOS-12, fabric, 3.8) success
install-pkg (macOS-12, fabric, 3.10) success
install-pkg (macOS-12, pytorch, 3.8) success
install-pkg (macOS-12, pytorch, 3.10) success
install-pkg (macOS-12, lightning, 3.8) success
install-pkg (macOS-12, lightning, 3.10) success
install-pkg (macOS-12, notset, 3.8) success
install-pkg (macOS-12, notset, 3.10) success
install-pkg (windows-2022, app, 3.8) success
install-pkg (windows-2022, app, 3.10) success
install-pkg (windows-2022, fabric, 3.8) success
install-pkg (windows-2022, fabric, 3.10) success
install-pkg (windows-2022, pytorch, 3.8) success
install-pkg (windows-2022, pytorch, 3.10) success
install-pkg (windows-2022, lightning, 3.8) success
install-pkg (windows-2022, lightning, 3.10) success
install-pkg (windows-2022, notset, 3.8) success
install-pkg (windows-2022, notset, 3.10) success

These checks are required after the changes to src/lightning/app/components/database/server.py, src/lightning/app/components/serve/auto_scaler.py, src/lightning/app/core/work.py, src/lightning/app/utilities/proxies.py, src/lightning/fabric/fabric.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/registry.py, src/lightning/fabric/wrappers.py, src/lightning/pytorch/trainer/connectors/callback_connector.py, src/lightning/pytorch/trainer/connectors/signal_connector.py, src/lightning/pytorch/utilities/imports.py, src/version.info.

🟢 link-check
Check ID Status
check-md-links / markdown-link-check success

These checks are required after the changes to src/lightning/app/CHANGELOG.md, src/lightning/fabric/CHANGELOG.md, src/lightning/pytorch/CHANGELOG.md.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda changed the title Additional release commits Additional release commits [rebase&merge] Jun 7, 2023
@Borda Borda requested review from Borda and edenlightning as code owners June 7, 2023 08:22
@Borda
Copy link
Collaborator

Borda commented Jun 7, 2023

added docs commit; cc: @edenlightning

@Borda Borda force-pushed the release-commits branch from bc2b44c to 0866e6d Compare June 7, 2023 08:36
@Borda Borda added the release label Jun 7, 2023
@Borda Borda force-pushed the release-commits branch from e3a9df4 to 6dec8fa Compare June 7, 2023 09:09
@Borda
Copy link
Collaborator

Borda commented Jun 7, 2023

pending on #17771

lightningforever and others added 5 commits June 7, 2023 12:48
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* update docs

* update docs index

* Delete version.info

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* update glossary

* typo

* restructure

* rm newline

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

(cherry picked from commit c2d9ec4)
@Borda Borda force-pushed the release-commits branch from 6dec8fa to 066c4e9 Compare June 7, 2023 10:48
@awaelchli awaelchli added this to the 2.0.x milestone Jun 7, 2023
@lantiga lantiga merged commit d90d404 into release/stable Jun 7, 2023
@lantiga lantiga deleted the release-commits branch June 7, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants