docs: include external pages 1/2 [habana] #17826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci
Contributor
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #17826 +/- ##
=========================================
+ Coverage 53% 68% +15%
=========================================
Files 420 425 +5
Lines 31918 32008 +90
=========================================
+ Hits 16973 21851 +4878
+ Misses 14945 10157 -4788 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Borda
requested review from
edenlightning,
lantiga and
williamFalcon
as code owners
jerome-habana
approved these changes
Jun 19, 2023
Contributor
jerome-habana
left a comment
jerome-habana
left a comment
There was a problem hiding this comment.
This change is needed for habana docs visibility along with the new releases plugins.
Collaborator
Author
cc: @lantiga |
lantiga
approved these changes
Jun 20, 2023
Borda
added a commit
that referenced
this pull request
Jun 21, 2023
* pull docs * local * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * replace * strategies * 1.0.0 * skip * links * more --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6b0ec10)
7 tasks
Borda
added a commit
that referenced
this pull request
Jun 21, 2023
* pull docs * local * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * replace * strategies * 1.0.0 * skip * links * more --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6b0ec10)
Borda
added a commit
that referenced
this pull request
Jun 22, 2023
* pull docs * local * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * replace * strategies * 1.0.0 * skip * links * more --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6b0ec10)
lantiga
pushed a commit
that referenced
this pull request
Jun 22, 2023
* pull docs * local * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * ... * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * replace * strategies * 1.0.0 * skip * links * more --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit 6b0ec10)
Borda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pulling Habana docsinside
using iframe would pull double left menu and miss indexing
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
cc @Borda @carmocca