docs: include external pages 2/2 [graphcore] #17890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

Borda merged 12 commits into master from docs/graphcore

Oct 3, 2023

Collaborator

Borda commented Jun 21, 2023 •

edited by github-actions bot

Loading

What does this PR do?

depends on Lightning-AI/lightning-Graphcore#22 and consecutive release/tag

(follow-up of #17826)

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @carmocca


          docs: include external pages

0d947cf

Borda added docs 3rd party labels

Borda added this to the 2.0.x milestone

Borda requested review from awaelchli, carmocca, edenlightning, lantiga and williamFalcon as code owners

June 21, 2023 15:51

github-actions bot added the pl label

Contributor

github-actions bot commented Jun 21, 2023 •

edited

Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.0)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.0)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.0)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
[pytorch-lightning (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177315&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success
[pytorch-lightning (GPUs) (testing PyTorch	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177315&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f)	success

These checks are required after the changes to .actions/assistant.py.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to docs/source-pytorch/accelerators/accelerator_prepare.rst, docs/source-pytorch/accelerators/ipu_advanced.rst, docs/source-pytorch/accelerators/ipu_basic.rst, docs/source-pytorch/accelerators/ipu_intermediate.rst, docs/source-pytorch/common/index.rst, docs/source-pytorch/common_usecases.rst, docs/source-pytorch/conf.py, docs/source-pytorch/extensions/accelerator.rst, docs/source-pytorch/extensions/strategy.rst, docs/source-pytorch/glossary/index.rst, docs/source-pytorch/integrations/ipu/index.rst, docs/source-pytorch/levels/advanced_level_19.rst, .actions/assistant.py.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.12, 11.7.1)	success	✅
build-cuda (3.9, 1.13, 11.8.0)	success	✅
build-cuda (3.9, 1.13, 12.0.1)	success	✅
build-cuda (3.10, 2.0, 11.8.0)	success	✅
build-cuda (3.10, 2.0, 12.0.1)	success	✅
build-pl (3.9, 1.12, 11.7.1)	success	✅
build-pl (3.9, 1.13, 11.8.0)	success	✅
build-pl (3.9, 1.13, 12.0.1)	success	✅
build-pl (3.10, 2.0, 11.8.0)	success	✅
build-pl (3.10, 2.0, 12.0.1)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_data: CPU workflow

Check ID	Status
data-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
data-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
data-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.0)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.0)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.0)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
[lightning-fabric (GPUs) (testing Fabric	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177316&view=logs&jobId=fe777007-6e77-5e50-6e71-fc5977ab193a)	success
[lightning-fabric (GPUs) (testing Lightning	latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=177316&view=logs&jobId=47e66f3c-897a-5428-da11-bf5c7745762e)	success

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (macOS-12, app, 3.11, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (ubuntu-22.04, app, 3.11, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅
app-pytest (windows-2022, app, 3.11, latest)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_app: Docs

Check ID	Status
docs-make (app, doctest)	success	✅
docs-make (app, html)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to .actions/assistant.py.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

Borda enabled auto-merge (squash)

June 21, 2023 15:51

Borda commented

View reviewed changes

docs/source-pytorch/conf.py Outdated Show resolved Hide resolved

Borda and others added 5 commits

July 3, 2023 20:56


          Merge branch 'master' into docs/graphcore

874ecea


          Merge branch 'master' into docs/graphcore

8a4f392


          Merge branch 'master' into docs/graphcore

8e016e2


          Apply suggestions from code review

58b1b35


          images

65a67ab

Borda requested a review from tchaton as a code owner

October 3, 2023 13:27


          orphans

37e014d

Borda requested review from ethanwharris and justusschock as code owners

October 3, 2023 13:43

github-actions bot added the ci label

pre-commit-ci bot and others added 3 commits

October 3, 2023 13:44


          [pre-commit.ci] auto fixes from pre-commit.com hooks

50f3612

for more information, see https://pre-commit.ci


          links

fe488ca


          Merge branch 'docs/graphcore' of https://github.com/PyTorchLightning/…

689bb75

…pytorch-lightning into docs/graphcore

Borda changed the title ~~docs: include external pages 2/2~~ docs: include external pages 2/2 [graphcore]


          [pre-commit.ci] auto fixes from pre-commit.com hooks

5bd5cb6

for more information, see https://pre-commit.ci

codecov bot commented Oct 3, 2023 •

edited

Loading

Codecov Report

Merging #17890 (9c03990) into master (9d9220c) will decrease coverage by 12%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #17890     +/-   ##
=========================================
- Coverage      83%      71%    -12%     
=========================================
  Files         428      428             
  Lines       33546    33546             
=========================================
- Hits        27985    23864   -4121     
- Misses       5561     9682   +4121

Borda removed this from the 2.0.x milestone

Borda added this to the 2.1 milestone

awaelchli approved these changes

View reviewed changes

carmocca approved these changes

View reviewed changes

mergify bot added the ready label


          Merge branch 'master' into docs/graphcore

9c03990

lantiga approved these changes

View reviewed changes

Borda merged commit 45237c7 into master

Borda deleted the docs/graphcore branch

October 3, 2023 19:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lantiga lantiga approved these changes

williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

edenlightning Awaiting requested review from edenlightning

tchaton Awaiting requested review from tchaton tchaton is a code owner

ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

justusschock Awaiting requested review from justusschock justusschock is a code owner

+2 more reviewers

awaelchli awaelchli approved these changes

carmocca carmocca approved these changes

Labels

3rd party ci docs pl ready