Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jun 16, 2023

What does this PR do?

collecting tests that show some instability...

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @Borda

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jun 16, 2023
@github-actions github-actions bot added the ci Continuous Integration label Jun 16, 2023
@Borda Borda changed the title tests: marking some flakiness tests: marking some flakiness [wip] Jun 16, 2023
@Borda Borda marked this pull request as ready for review June 16, 2023 12:00
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, lightning, 3.8, 1.11) success
pl-cpu (macOS-11, lightning, 3.9, 1.12) success
pl-cpu (macOS-11, lightning, 3.10, 1.13) success
pl-cpu (macOS-11, lightning, 3.10, 2.0) success
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
pl-cpu (windows-2022, lightning, 3.8, 1.11) success
pl-cpu (windows-2022, lightning, 3.9, 1.12) success
pl-cpu (windows-2022, lightning, 3.10, 1.13) success
pl-cpu (windows-2022, lightning, 3.10, 2.0) success
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
pl-cpu (macOS-11, pytorch, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13) success
pl-cpu (windows-2022, pytorch, 3.8, 1.13) success

These checks are required after the changes to tests/tests_pytorch/utilities/test_all_gather_grad.py.

🟢 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) success

These checks are required after the changes to tests/tests_pytorch/utilities/test_all_gather_grad.py.

🟢 lightning_app: Tests workflow
Check ID Status
app-pytest (macOS-11, lightning, 3.8, latest) success
app-pytest (macOS-11, lightning, 3.8, oldest) success
app-pytest (macOS-11, app, 3.9, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, latest) success
app-pytest (ubuntu-20.04, lightning, 3.8, oldest) success
app-pytest (ubuntu-20.04, app, 3.9, latest) success
app-pytest (windows-2022, lightning, 3.8, latest) success
app-pytest (windows-2022, lightning, 3.8, oldest) success
app-pytest (windows-2022, app, 3.8, latest) success

These checks are required after the changes to .github/workflows/ci-tests-app.yml, tests/tests_app/utilities/test_proxies.py.

🟢 lightning_app: Examples
Check ID Status
app-examples (macOS-11, lightning, 3.9, latest) success
app-examples (macOS-11, lightning, 3.9, oldest) success
app-examples (macOS-11, app, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, latest) success
app-examples (ubuntu-20.04, lightning, 3.9, oldest) success
app-examples (ubuntu-20.04, app, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, latest) success
app-examples (windows-2022, lightning, 3.9, oldest) success
app-examples (windows-2022, app, 3.9, latest) success

These checks are required after the changes to .github/workflows/ci-examples-app.yml.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #17849 (d4a43f7) into master (0079b6d) will decrease coverage by 4%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #17849     +/-   ##
=========================================
- Coverage      83%      79%     -4%     
=========================================
  Files         425      422      -3     
  Lines       32004    31949     -55     
=========================================
- Hits        26602    25384   -1218     
- Misses       5402     6565   +1163     

@Borda Borda requested review from lantiga and tchaton as code owners June 16, 2023 18:23
@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Jun 16, 2023
@Borda Borda changed the title tests: marking some flakiness [wip] tests: marking some flakiness Jun 20, 2023
@Borda Borda enabled auto-merge (squash) June 20, 2023 21:38
@Borda Borda merged commit ba943e3 into master Jun 21, 2023
@Borda Borda deleted the tests/flaky branch June 21, 2023 06:44
@mergify mergify bot added the ready PRs ready to be merged label Jun 21, 2023
Borda added a commit that referenced this pull request Jun 21, 2023
lantiga pushed a commit that referenced this pull request Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants