Skip to content

tests: marking some flakiness #17849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023
Merged

tests: marking some flakiness #17849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49a83f4
test_all_gather_ddp_spawn
Borda Jun 16, 2023
73df5d2
app: timeout=120
Borda Jun 16, 2023
d4a43f7
test_work_runner
Borda Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci-examples-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ jobs:
run: |
python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
-m pytest -m "not cloud" integrations_app \
--timeout=300 --durations=0 -vvvv
--timeout=120 --durations=0 -vvvv

- name: Statistics
if: success()
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-tests-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
AWS_DEFAULT_REGION: us-east-1
run: |
python -m coverage run --source ${{ env.COVERAGE_SCOPE }} \
-m pytest -m "not cloud" tests_app --timeout=300 -vvvv --durations=50
-m pytest -m "not cloud" tests_app --timeout=120 -vvvv --durations=50

- name: Statistics
if: success()
Expand Down
1 change: 1 addition & 0 deletions tests/tests_app/utilities/test_proxies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ def proxy_setattr():
],
)
@mock.patch("lightning.app.utilities.proxies._Copier", MagicMock())
@pytest.mark.flaky(reruns=3)
@pytest.mark.xfail(sys.platform == "win32", strict=False, reason="Fix this on Windows") # TODO @ethanwharris
def test_work_runner(parallel, cache_calls, *_):
"""This test validates the `WorkRunner` runs the work.run method and properly populates the `delta_queue`,
Expand Down
2 changes: 2 additions & 0 deletions tests/tests_pytorch/utilities/test_all_gather_grad.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

import numpy as np
import pytest
import torch

from lightning.pytorch import Trainer
Expand Down Expand Up @@ -45,6 +46,7 @@ def all_gather_ddp_spawn_fn(strategy):


@RunIf(skip_windows=True)
@pytest.mark.flaky(reruns=3)
def test_all_gather_ddp_spawn():
spawn_launch(all_gather_ddp_spawn_fn, [torch.device("cpu")] * 3)

Expand Down