Skip to content

Conversation

@mauvilsa
Copy link
Contributor

@mauvilsa mauvilsa commented Mar 21, 2024

What does this PR do?

Re-enables the test_ddpstrategy_instantiation_and_find_unused_parameters test which was disabled because of omni-us/jsonargparse#473

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--19683.org.readthedocs.build/en/19683/

…hich was skipped because of bug in jsonargparse.
@mauvilsa mauvilsa marked this pull request as ready for review March 21, 2024 15:49
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 21, 2024
@mauvilsa mauvilsa requested a review from lantiga as a code owner March 21, 2024 15:49
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Mar 21, 2024
@mauvilsa mauvilsa requested a review from tchaton as a code owner March 21, 2024 15:49
@mauvilsa mauvilsa changed the title Re-enable LightningCLI test required due to bug in jsonargparse Re-enable LightningCLI test disabled due to bug in jsonargparse Mar 21, 2024
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mauvilsa, very nice!

@awaelchli awaelchli added this to the 2.2.x milestone Mar 21, 2024
@awaelchli awaelchli added community This PR is from the community tests labels Mar 21, 2024
@mergify mergify bot added the ready PRs ready to be merged label Mar 21, 2024
@awaelchli awaelchli merged commit 6cfc590 into Lightning-AI:master Mar 22, 2024
@mauvilsa mauvilsa deleted the cli-reenable-test branch March 22, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR is from the community dependencies Pull requests that update a dependency file pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants