-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Catch issue with partial mpi4py installation. #21353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Depending on precise install, mpi4py may be installed without `MPI` being present. Catch that case in the detect() function, and treat it as if mpi4py is not installed.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21353 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 269 269
Lines 23796 23799 +3
=======================================
+ Hits 20617 20618 +1
- Misses 3179 3181 +2 |
|
@roccomoretti , thanks for this PR. Could you please add a section to the Changelog? |
|
@justusschock Where is the Changelog? There doesn't seem to be a changelog.md or the like in the root directory, nor is there any link or mention of the changelog in the contributor guidelines. |
|
@roccomoretti apologies for being less clear. I'll also update the contributor guidelines. For fabric (where you updated things) it's here: https://github.com/Lightning-AI/pytorch-lightning/blob/master/src/lightning/fabric/CHANGELOG.md |
|
Hi @roccomoretti, I believe it makes sense to add a brief comment on why this |
What does this PR do?
Depending on precise install conditions, mpi4py may be installed without
MPIbeing present, which can cause an ImportError. ("cannot import name 'MPI' from 'mpi4py'").Catch that case in the detect() function of the MPI plugin, and treat it as if mpi4py is not installed.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21353.org.readthedocs.build/en/21353/