Skip to content

enable testing DDP examples #4995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 15, 2021
Merged

enable testing DDP examples #4995

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
54c0d07
enable testing DDP examples
Borda Dec 7, 2020
ed6b367
args
Borda Dec 7, 2020
6339d33
ddp_spawn
Borda Dec 7, 2020
61b299c
ddp as extra script
Borda Dec 17, 2020
df15e94
path
Borda Feb 12, 2021
f836bd6
install
Borda Feb 12, 2021
5cffd47
-u
Borda Feb 12, 2021
4e5f3cb
q
Borda Feb 12, 2021
978bdf2
-y
Borda Feb 12, 2021
30e115b
Merge branch 'master' into tests/examples-ddp
mergify[bot] Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,3 +88,9 @@ jobs:
- script: |
python -m pytest benchmarks pl_examples -v --maxfail=2 --durations=0
displayName: 'Testing: extended'

- script: |
python setup.py install --user --quiet
bash pl_examples/run_ddp-example.sh
pip uninstall -y pytorch-lightning
displayName: 'Examples'
12 changes: 12 additions & 0 deletions pl_examples/run_ddp-example.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
#!/bin/bash

ARGS_DEFAULT=" --default_root_dir %(tmpdir)s --max_epochs 1 --batch_size 32 --limit_train_batches 2 --limit_val_batches 2"
ARGS_EXTRA_DDP=" --gpus 2 --accelerator ddp"
ARGS_EXTRA_AMP=" --precision 16"

python pl_examples/basic_examples/simple_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
python pl_examples/basic_examples/simple_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
python pl_examples/basic_examples/backbone_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
python pl_examples/basic_examples/backbone_image_classifier.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
python pl_examples/basic_examples/autoencoder.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP}
python pl_examples/basic_examples/autoencoder.py ${ARGS_DEFAULT} ${ARGS_EXTRA_DDP} ${ARGS_EXTRA_AMP}
32 changes: 2 additions & 30 deletions pl_examples/test_examples.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,7 @@
--accelerator dp \
"""

ARGS_DP_AMP = ARGS_DP + """
--precision 16 \
"""

ARGS_DDP = ARGS_DEFAULT + """
--gpus 2 \
--accelerator ddp \
--precision 16 \
"""

ARGS_DDP_AMP = ARGS_DEFAULT + """
ARGS_AMP = """
--precision 16 \
"""

Expand All @@ -61,7 +51,7 @@
]
)
@pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
@pytest.mark.parametrize('cli_args', [ARGS_DP, ARGS_DP_AMP])
@pytest.mark.parametrize('cli_args', [ARGS_DP, ARGS_DP + ARGS_AMP])
def test_examples_dp(tmpdir, import_cli, cli_args):

module = importlib.import_module(import_cli)
Expand All @@ -72,24 +62,6 @@ def test_examples_dp(tmpdir, import_cli, cli_args):
module.cli_main()


# ToDo: fix this failing example
# @pytest.mark.parametrize('import_cli', [
# 'pl_examples.basic_examples.simple_image_classifier',
# 'pl_examples.basic_examples.backbone_image_classifier',
# 'pl_examples.basic_examples.autoencoder',
# ])
# @pytest.mark.skipif(torch.cuda.device_count() < 2, reason="test requires multi-GPU machine")
# @pytest.mark.parametrize('cli_args', [ARGS_DDP, ARGS_DDP_AMP])
# def test_examples_ddp(tmpdir, import_cli, cli_args):
#
# module = importlib.import_module(import_cli)
# # update the temp dir
# cli_args = cli_args % {'tmpdir': tmpdir}
#
# with mock.patch("argparse._sys.argv", ["any.py"] + cli_args.strip().split()):
# module.cli_main()


@pytest.mark.parametrize(
'import_cli', [
'pl_examples.basic_examples.simple_image_classifier',
Expand Down