Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 15, 2021

What does this PR do?

On master, a deprecation message is shown due to an internal call in ModelCheckpoint to trainer.train_loop, which was renamed to fit_loop.

LightningDeprecationWarning: `Trainer.train_loop` has been renamed to `Trainer.fit_loop` and will be removed in v1.6.
  rank_zero_deprecation(

This issue is not present in any releases, no changelog needed.

Does your PR introduce any breaking changes ? If yes, please list them.

no

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added the bug Something isn't working label Jul 15, 2021
@awaelchli awaelchli added this to the v1.3.x milestone Jul 15, 2021
@awaelchli awaelchli added the ready PRs ready to be merged label Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #8434 (17f2ae5) into master (176df20) will decrease coverage by 5%.
The diff coverage is 100%.

❗ Current head 17f2ae5 differs from pull request most recent head 4d77e6d. Consider uploading reports for the commit 4d77e6d to get more accurate results

@@           Coverage Diff           @@
##           master   #8434    +/-   ##
=======================================
- Coverage      93%     88%    -5%     
=======================================
  Files         216     216            
  Lines       14109   14109            
=======================================
- Hits        13083   12421   -662     
- Misses       1026    1688   +662     

@awaelchli awaelchli merged commit 8c5042e into master Jul 16, 2021
@awaelchli awaelchli deleted the bugfix/train-loop-deprecation-warn branch July 16, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants