Skip to content

Conversation

@christopherfish
Copy link
Contributor

@christopherfish christopherfish commented Aug 12, 2021

What does this PR do?

train_loop was renamed to fit_loop, but an internal call to train_loop remained causing warnings. This PR fixes those calls.

This PR is a similar fix (to the same file!) #8434

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@ananthsub ananthsub enabled auto-merge (squash) August 12, 2021 17:25
@ananthsub ananthsub disabled auto-merge August 12, 2021 17:25
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #8873 (a158bf5) into master (5fd157e) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #8873    +/-   ##
=======================================
- Coverage      93%     89%    -4%     
=======================================
  Files         169     169            
  Lines       14078   14078            
=======================================
- Hits        13052   12474   -578     
- Misses       1026    1604   +578     

@mergify mergify bot added the ready PRs ready to be merged label Aug 12, 2021
@awaelchli awaelchli added this to the v1.4.x milestone Aug 13, 2021
@awaelchli awaelchli added the bug Something isn't working label Aug 13, 2021
@awaelchli awaelchli merged commit 0749c1e into Lightning-AI:master Aug 13, 2021
@awaelchli
Copy link
Contributor

Thanks @christopherfish !!

four4fish pushed a commit to four4fish/pytorch-lightning that referenced this pull request Aug 16, 2021
kaushikb11 pushed a commit to kaushikb11/pytorch-lightning that referenced this pull request Aug 18, 2021
lexierule pushed a commit that referenced this pull request Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants