Skip to content

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Aug 2, 2021

What does this PR do?

Fixed by #8116 and/or #6208

Part of #6935

tests/models/test_horovod.py::test_horovod_multi_optimizer PASSED        [ 48%]
tests/models/test_horovod.py::test_horovod_multi_optimizer_with_scheduling_stepping PASSED [ 48%]

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@carmocca carmocca added ci Continuous Integration 3rd party Related to a 3rd-party labels Aug 2, 2021
@carmocca carmocca added this to the v1.5 milestone Aug 2, 2021
@carmocca carmocca self-assigned this Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #8676 (8d75b59) into master (7a1e972) will increase coverage by 4%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #8676    +/-   ##
=======================================
+ Coverage      88%     93%    +4%     
=======================================
  Files         168     168            
  Lines       13984   13985     +1     
=======================================
+ Hits        12354   12951   +597     
+ Misses       1630    1034   -596     

@carmocca carmocca changed the title [WIP] Undo skipping for some Horovod tests Un-skip some Horovod tests Aug 2, 2021
@carmocca carmocca marked this pull request as ready for review August 2, 2021 11:59
@carmocca carmocca enabled auto-merge (squash) August 2, 2021 12:01
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Aug 2, 2021
@carmocca carmocca merged commit d187008 into master Aug 2, 2021
@carmocca carmocca deleted the ci/horovod-unskip branch August 2, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3rd party Related to a 3rd-party ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants