Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 12, 2021

What does this PR do?

Splits out changes from #9764

The changed tests here rely on accessing the patched model.x_dataloader().
Making this a separate PR ensures the integrity of the tests and that there is no unintended coupling with changes in #9764.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added ci Continuous Integration refactor labels Oct 12, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 12, 2021
@awaelchli awaelchli marked this pull request as ready for review October 12, 2021 09:24
@awaelchli awaelchli changed the title update tests not to rely on patched dataloaders update tests to not rely on patched dataloaders Oct 12, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Oct 12, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 12, 2021 09:40
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #9905 (f187078) into master (f16bfe9) will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #9905    +/-   ##
=======================================
- Coverage      93%     92%    -1%     
=======================================
  Files         178     178            
  Lines       15647   15796   +149     
=======================================
+ Hits        14502   14559    +57     
- Misses       1145    1237    +92     

@awaelchli awaelchli merged commit b530b7a into master Oct 12, 2021
@awaelchli awaelchli deleted the tests/data branch October 12, 2021 10:45
rohitgr7 pushed a commit to Tshimanga/pytorch-lightning that referenced this pull request Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants