Conversation
for more information, see https://pre-commit.ci
d5b48d3 to
c2e6155
Compare
c2e6155 to
4347bb0
Compare
8736d5e to
bd67860
Compare
bb6ee00 to
07a3d77
Compare
|
@ethanwharris cold ou pls check that the thumb pat is correct after refactor 🐰 |
justusschock
left a comment
There was a problem hiding this comment.
Can we not include the thumbnail as png here and maybe store it on s3? Once added we never get rid of it from the history and since it's binary every change will be tracked as a new file.
I know that this file is not that large but since we already have a quite large history and every bit counts, I'd rather not add this
I would not have much concern about thumbnails, but rather all other illustrations... |
ethanwharris
left a comment
There was a problem hiding this comment.
@Borda Seems to be working, LGTM 😃
Before submitting
What does this PR do?
working with bash/shell is just pain 😃
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃