Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Fine-Tuning Scheduler Tutorial Update for Lightning/PyTorch 2.1.0#278

Merged
Borda merged 4 commits intoLightning-AI:mainfrom
speediedan:fts_updates_2.1.0
Oct 14, 2023
Merged

Fine-Tuning Scheduler Tutorial Update for Lightning/PyTorch 2.1.0#278
Borda merged 4 commits intoLightning-AI:mainfrom
speediedan:fts_updates_2.1.0

Conversation

@speediedan
Copy link
Copy Markdown
Contributor

Validated the Fine-Tuning Scheduler (FTS) tutorial for FTS/Lightning/PyTorch 2.1.0 (as of the final PyTorch RC and the latest 2.1.0 Lightning commit).

The only minor change in this PR is to remove an ephemeral yaml fine-tuning schedule.

Note that due to an apparent internal issue with tutorial publishing, the Fine-Tuning Scheduler 2.0 tutorial update was successfully committed but was never published. Since the aforementioned papermill job issue was unfortunately never isolated/resolved 1, I'm hoping this PR can be successfully merged and the publish validated to ensure the Fine-Tuning Scheduler tutorial gets updated for the upcoming 2.1.0 release.

Thank you for all your work and your consistently valuable contributions to the open-source ML community!

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Updates the Fine-Tuning Scheduler tutorial to better support 2.1.0 and prepare for 2.1.0 tutorial publishing.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

Footnotes

  1. In case the issue re-emerges (since the original Azure build logs containing the error have been purged) I should note that I could not reproduce the git-lfs error (in the 'Git check & switch branch' step) of the papermill job in a local container but that the updated tutorial was ready to be published. Remotely failed Git check & switch branch working locally: ```
    root@57ded931c266:/fts_tutorial# git fetch --all
    Fetching origin
    root@57ded931c266:/fts_tutorial# git ls-remote --heads origin publication | grep publication >/dev/null
    root@57ded931c266:/fts_tutorial# if [ "$?" == "1" ] ; then echo "Branch doesn't exist"; exit; fi
    root@57ded931c266:/fts_tutorial# git checkout publication
    Already on 'publication'
    Your branch is up to date with 'origin/publication'.
    root@57ded931c266:/fts_tutorial# git show-ref publication
    491d2cf refs/heads/publication
    491d2cf refs/remotes/origin/publication
    root@57ded931c266:/fts_tutorial# git pull
    Already up to date.

@mergify mergify Bot requested a review from Borda October 2, 2023 20:22
@speediedan speediedan marked this pull request as ready for review October 2, 2023 20:41
@speediedan
Copy link
Copy Markdown
Contributor Author

speediedan commented Oct 2, 2023

Marked "Ready for Review" despite the failing check as the check failure is due to an issue with the 'Install Sudo in container' step. Thanks again for your work! Certainly let me know if there's anything I can do to help out debugging this.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 4, 2023

Codecov Report

Merging #278 (34cd179) into main (a22e269) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #278   +/-   ##
===================================
  Coverage    71%    71%           
===================================
  Files         2      2           
  Lines       399    399           
===================================
  Hits        285    285           
  Misses      114    114           

@speediedan
Copy link
Copy Markdown
Contributor Author

LOVE this new workflow to keep tutorials updated! YOU'RE AWEOME Jirka!

Any chance we can get this FTS update PR merged prior to the automated tutorial update that is scheduled to run this Sunday at midnight? I noticed there's a layout issue with the current version that would be addressed by the automated update so the new workflow is already bearing fruit!!! Thanks again!
@Borda @carmocca

@Borda Borda merged commit fb7e973 into Lightning-AI:main Oct 14, 2023
@speediedan
Copy link
Copy Markdown
Contributor Author

awesome 🚀, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants