This repository was archived by the owner on Aug 28, 2025. It is now read-only.
Fine-Tuning Scheduler Tutorial Update for Lightning/PyTorch 2.1.0#278
Merged
Borda merged 4 commits intoLightning-AI:mainfrom Oct 14, 2023
Merged
Fine-Tuning Scheduler Tutorial Update for Lightning/PyTorch 2.1.0#278Borda merged 4 commits intoLightning-AI:mainfrom
Borda merged 4 commits intoLightning-AI:mainfrom
Conversation
…l yaml schedule file.
Contributor
Author
|
Marked "Ready for Review" despite the failing check as the check failure is due to an issue with the 'Install Sudo in container' step. Thanks again for your work! Certainly let me know if there's anything I can do to help out debugging this. |
Borda
approved these changes
Oct 3, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #278 +/- ##
===================================
Coverage 71% 71%
===================================
Files 2 2
Lines 399 399
===================================
Hits 285 285
Misses 114 114 |
…ity but led to unreliable rendering
Contributor
Author
|
LOVE this new workflow to keep tutorials updated! YOU'RE AWEOME Jirka! Any chance we can get this FTS update PR merged prior to the automated tutorial update that is scheduled to run this Sunday at midnight? I noticed there's a layout issue with the current version that would be addressed by the automated update so the new workflow is already bearing fruit!!! Thanks again! |
Borda
approved these changes
Oct 14, 2023
Contributor
Author
|
awesome 🚀, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validated the Fine-Tuning Scheduler (FTS) tutorial for FTS/Lightning/PyTorch
2.1.0(as of the final PyTorch RC and the latest2.1.0Lightning commit).The only minor change in this PR is to remove an ephemeral yaml fine-tuning schedule.
Note that due to an apparent internal issue with tutorial publishing, the Fine-Tuning Scheduler 2.0 tutorial update was successfully committed but was never published. Since the aforementioned
papermilljob issue was unfortunately never isolated/resolved 1, I'm hoping this PR can be successfully merged and the publish validated to ensure the Fine-Tuning Scheduler tutorial gets updated for the upcoming2.1.0release.Thank you for all your work and your consistently valuable contributions to the open-source ML community!
Before submitting
What does this PR do?
Updates the Fine-Tuning Scheduler tutorial to better support
2.1.0and prepare for2.1.0tutorial publishing.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
Footnotes
In case the issue re-emerges (since the original Azure build logs containing the error have been purged) I should note that I could not reproduce the
git-lfserror (in the'Git check & switch branch'step) of thepapermilljob in a local container but that the updated tutorial was ready to be published. Remotely failedGit check & switch branchworking locally: ```root@57ded931c266:/fts_tutorial# git fetch --all
Fetching origin
root@57ded931c266:/fts_tutorial# git ls-remote --heads origin publication | grep publication >/dev/null
root@57ded931c266:/fts_tutorial# if [ "$?" == "1" ] ; then echo "Branch doesn't exist"; exit; fi
root@57ded931c266:/fts_tutorial# git checkout publication
Already on 'publication'
Your branch is up to date with 'origin/publication'.
root@57ded931c266:/fts_tutorial# git show-ref publication
491d2cf refs/heads/publication
491d2cf refs/remotes/origin/publication
root@57ded931c266:/fts_tutorial# git pull
Already up to date. ↩