Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

Conversation

@edgarriba
Copy link
Contributor

@edgarriba edgarriba commented Jun 11, 2021

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Jun 11, 2021

Hello @edgarriba! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-06-15 12:27:41 UTC

@edgarriba edgarriba added the Example Example / Demo / Tutorial label Jun 11, 2021
@Borda Borda added the enhancement New feature or request label Jun 11, 2021
@edgarriba
Copy link
Contributor Author

@Borda can we just set one single gpu ? now the azure pipeline is failing possibly for this reason

@Borda
Copy link
Contributor

Borda commented Jun 14, 2021

@Borda can we just set one single gpu ? now the azure pipeline is failing possibly for this reason

sure, I did the same in other notebooks too

@edgarriba
Copy link
Contributor Author

@Borda green lights. Please, review again.

@edgarriba
Copy link
Contributor Author

@Borda any idea why docs are still failing ?

@Borda
Copy link
Contributor

Borda commented Jun 15, 2021

@Borda any idea why docs are still failing?

you need to resolve all WARNING: Title level inconsistent which is also what I told you here #28 (comment)

@edgarriba
Copy link
Contributor Author

@Borda green lights again. The gpus trick worked this time - black magic :)

@Borda Borda enabled auto-merge (squash) June 15, 2021 12:08
@Borda Borda merged commit f893291 into main Jun 15, 2021
@Borda Borda deleted the kornia branch June 15, 2021 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request Example Example / Demo / Tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants