Skip to content
This repository was archived by the owner on Aug 28, 2025. It is now read-only.

assistant: try copy notebook else warn#288

Merged
Borda merged 1 commit intomainfrom
assist/try-copy
Oct 13, 2023
Merged

assistant: try copy notebook else warn#288
Borda merged 1 commit intomainfrom
assist/try-copy

Conversation

@Borda
Copy link
Copy Markdown
Contributor

@Borda Borda commented Oct 13, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

try to make a notebook copy and if fail warn about the error and not crash...
this helps in multiple directions:

  • allow skip failing notebooks so as not to block docs build
  • add notebook name so we can track back with multi-job build
  • still can enforce full docs build with treating warnings as error

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug / fix Something isn't working enhancement New feature or request labels Oct 13, 2023
@Borda Borda requested a review from ethanwharris as a code owner October 13, 2023 08:29
@github-actions github-actions Bot added the ci/cd label Oct 13, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2023

Codecov Report

Merging #288 (3962aaa) into main (dc01f0b) will decrease coverage by 1%.
The diff coverage is 17%.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #288   +/-   ##
===================================
- Coverage    72%    71%   -1%     
===================================
  Files         2      2           
  Lines       394    399    +5     
===================================
+ Hits        284    285    +1     
- Misses      110    114    +4     

@Borda Borda merged commit d2561fb into main Oct 13, 2023
@Borda Borda deleted the assist/try-copy branch October 13, 2023 10:44
@Borda Borda changed the title assitent: try copy notebok else warn assistant: try copy notebook else warn Oct 13, 2023
@Borda Borda mentioned this pull request Oct 13, 2023
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug / fix Something isn't working ci/cd enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant