Remove deprecated pkg_resources usage for setuptools >= 82 compatibility#473
Merged
tchaton merged 14 commits intoLightning-AI:mainfrom Feb 10, 2026
Merged
Conversation
bhimrazy
requested review from
ethanwharris,
justusschock,
lantiga and
tchaton
as code owners
for more information, see https://pre-commit.ci
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=====================================
Coverage ? 72%
=====================================
Files ? 17
Lines ? 751
Branches ? 0
=====================================
Hits ? 541
Misses ? 210
Partials ? 0 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
bhimrazy
changed the title
pkg resources dependencypkg_resources usage for setuptools >= 82 compatibility
bhimrazy
changed the title
pkg_resources usage for setuptools >= 82 compatibilitypkg_resources usage for setuptools >= 82 compatibility
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates lightning_utilities to remain compatible with setuptools >= 82 by removing the deprecated/removed pkg_resources dependency and migrating requirement/version parsing to packaging.
Changes:
- Replaced
pkg_resourcesusage in requirements parsing withpackagingequivalents. - Switched version sorting/parsing from
distutils.version.LooseVersiontopackaging.version.Version. - Added unit tests covering requirements parsing and unfreeze strategies.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/lightning_utilities/install/requirements.py |
Replaces pkg_resources parsing/types and LooseVersion with packaging and adds a local yield_lines. |
setup.py |
Replaces pkg_resources.parse_requirements with a local parser based on packaging.Requirement. |
src/lightning_utilities/docs/formatting.py |
Uses packaging.version.Version for sorting PyPI versions. |
tests/unittests/install/test_requirements.py |
Adds unit tests for yield_lines, requirement parsing, and adjust() behavior. |
pyproject.toml |
Adds packaging to build-system requirements. |
CHANGELOG.md |
Documents the compatibility fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…orresponding tests
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
for more information, see https://pre-commit.ci
tchaton
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes compatibility issue with setuptools >= 82 by removing
pkg_resourceswhich was removed in setuptools v82.0.0 (08 Feb 2026).Changes
pkg_resources.parse_requirementswithpackaging.requirements.Requirementpkg_resources.Requirementandyield_lineswithpackagingequivalentsdistutils.version.LooseVersionwithpackaging.version.Versionadjust()method to useself.specifierinstead of deprecatedself.specsWhy
pkg_resourceswas removed from setuptools v82.0.0, causing import errors. This PR migrates to thepackaginglibrary which is already a dependency.PR review
Anyone in the community is free to review the PR once the tests have passed.
Did you have fun?
Make sure you had fun coding 🙃
-->
📚 Documentation preview 📚: https://lit-utilities--473.org.readthedocs.build/en/473/