fix: add forward headers to LNBits calls for LNURL generation#183
Merged
TaprootFreak merged 1 commit intodevelopfrom May 8, 2026
Merged
fix: add forward headers to LNBits calls for LNURL generation#183TaprootFreak merged 1 commit intodevelopfrom
TaprootFreak merged 1 commit intodevelopfrom
Conversation
89cf351 to
748957c
Compare
LNBits generates LNURLs from the incoming request URL. In the Docker setup, internal calls arrive as http://lnbits:5000/... which fails LNURL validation (requires HTTPS or localhost). Use Config.baseUrl (dev.lightning.space / lightning.space / localhost) to set Host and X-Forwarded-Proto headers on all LNBits HTTP calls.
748957c to
9693d5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
http://lnbits:5000/...which fails LNURL validation (requires HTTPS or localhost/onion)LIGHTNING_LNBITS_SITE_URLenv var (e.g.https://dev.lightning.space) that injectsHostandX-Forwarded-Protoheaders into all LNBits HTTP callshttps://dev.lightning.space/lnurlp/api/v1/lnurl/cb/{id}Changes
config.ts: addsiteUrlconfig fromLIGHTNING_LNBITS_SITE_URLlightning-client.ts: addlnBitsForwardHeaders()helper, wire intohttpLnBitsConfig().env.example: document new env varlightning-client.ts(was unformatted)Deployment
After merge, add to Vaultwarden items:
LIGHTNING_LNBITS_SITE_URL=https://dev.lightning.spaceLIGHTNING_LNBITS_SITE_URL=https://lightning.spaceTest plan
LIGHTNING_LNBITS_SITE_URL=https://dev.lightning.spacein DEV envPOST /v1/auth/sign-upreturns 201 with accessTokenInvalidUrlerrors