fix(pricing): await currencies load in CoinGeckoService.onModuleInit#187
Merged
Conversation
The onModuleInit method used void-promise pattern, leaving this.currencies undefined until the async call resolved. If MonitoringService cron fired before that (which it does on container start), getCurrency() crashed with "Cannot read properties of undefined (reading 'find')". Make onModuleInit properly async with try/catch to preserve original resilience (CoinGecko outage at startup should not crash app startup) while adding error logging.
TaprootFreak
force-pushed
the
fix/coingecko-await-init
branch
from
e59a9d7 to
d8bc93a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CoinGeckoService.onModuleInit()started loading supported currencies with a void promise (no await)MonitoringService.processBalances()fires before that promise resolves (typical on container startup),getCurrency()crashes withCannot read properties of undefined (reading 'find')onModuleInitproperly async so NestJS waits for the currencies load before app starts servingTest plan
Cannot read properties of undefined (reading 'find')errors in container startup logs