Skip to content

fix: prover on cli startup and bump alpha #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SwenSchaeferjohann merged 1 commit into from
Jan 6, 2026
Merged

fix: prover on cli startup and bump alpha #2138

SwenSchaeferjohann merged 1 commit into from
Jan 6, 2026

Conversation

@SwenSchaeferjohann
Copy link
Contributor

@SwenSchaeferjohann SwenSchaeferjohann commented Dec 17, 2025

  • alpha.4 / 5
  • we want to run ci here

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 17, 2025 •
edited
Loading

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (39)
  • .github/workflows/js-v2.yml is excluded by none and included by none
  • cli/package.json is excluded by none and included by none
  • cli/src/utils/constants.ts is excluded by none and included by none
  • cli/src/utils/initTestEnv.ts is excluded by none and included by none
  • cli/src/utils/process.ts is excluded by none and included by none
  • cli/src/utils/processPhotonIndexer.ts is excluded by none and included by none
  • cli/src/utils/processProverServer.ts is excluded by none and included by none
  • js/compressed-token/package.json is excluded by none and included by none
  • js/compressed-token/src/actions/merge-token-accounts.ts is excluded by none and included by none
  • js/compressed-token/src/program.ts is excluded by none and included by none
  • js/compressed-token/src/v3/actions/create-mint-interface.ts is excluded by none and included by none
  • js/compressed-token/src/v3/actions/get-or-create-ata-interface.ts is excluded by none and included by none
  • js/compressed-token/src/v3/actions/load-ata.ts is excluded by none and included by none
  • js/compressed-token/src/v3/actions/transfer-interface.ts is excluded by none and included by none
  • js/compressed-token/src/v3/ata-utils.ts is excluded by none and included by none
  • js/compressed-token/src/v3/get-account-interface.ts is excluded by none and included by none
  • js/compressed-token/src/v3/instructions/create-mint.ts is excluded by none and included by none
  • js/compressed-token/src/v3/instructions/transfer-interface.ts is excluded by none and included by none
  • js/compressed-token/src/v3/layout/layout-mint-action.ts is excluded by none and included by none
  • js/compressed-token/src/v3/unified/index.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/create-compressed-mint.test.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/get-account-interface.test.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/get-or-create-ata-interface.test.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/load-ata-standard.test.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/load-ata-unified.test.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/merge-token-accounts.test.ts is excluded by none and included by none
  • js/compressed-token/tests/e2e/transfer-interface.test.ts is excluded by none and included by none
  • js/compressed-token/tests/unit/mint-action-layout.test.ts is excluded by none and included by none
  • js/compressed-token/vitest.config.ts is excluded by none and included by none
  • js/stateless.js/package.json is excluded by none and included by none
  • js/stateless.js/src/constants.ts is excluded by none and included by none
  • js/stateless.js/src/devnet-compat.ts is excluded by none and included by none
  • js/stateless.js/src/index.ts is excluded by none and included by none
  • js/stateless.js/src/rpc.ts is excluded by none and included by none
  • js/stateless.js/src/test-helpers/test-rpc/get-parsed-events.ts is excluded by none and included by none
  • js/stateless.js/src/utils/get-state-tree-infos.ts is excluded by none and included by none
  • js/stateless.js/tests/e2e/browser/rpc.browser.spec.ts is excluded by none and included by none
  • js/stateless.js/tests/unit/utils/tree-info.test.ts is excluded by none and included by none
  • scripts/devenv/versions.sh is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-prover-dl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SwenSchaeferjohann SwenSchaeferjohann force-pushed the fix-prover-dl branch 3 times, most recently from 37cba44 to bcfaada Compare December 21, 2025 14:12
ananas-block
ananas-block reviewed Dec 23, 2025
View reviewed changes
js/compressed-token/src/v3/actions/transfer-interface.ts
return cu;
// TODO: dynamic
// return cu;
return 200_000;
Copy link
Contributor

@ananas-block ananas-block Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with how many inputs and zkp does this work?

ananas-block
ananas-block reviewed Dec 23, 2025
View reviewed changes
scripts/devenv/versions.sh
export PHOTON_VERSION="0.51.2"
export PHOTON_COMMIT="3dbfb8e6772779fc89c640b5b0823b95d1958efc"
# current main (ci fails): 3dbfb8e6772779fc89c640b5b0823b95d1958efc
export PHOTON_COMMIT="ac7df6c388db847b7693a7a1cb766a7c9d7809b5"
Copy link
Contributor

@ananas-block ananas-block Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are the required photon changes?

@ananas-block
Copy link
Contributor

ananas-block commented Dec 23, 2025

else lgtm

@SwenSchaeferjohann SwenSchaeferjohann force-pushed the fix-prover-dl branch 3 times, most recently from 6925478 to a30cd58 Compare January 5, 2026 18:45
@SwenSchaeferjohann
fix prover dl
f0e3a5d 
bump cli alpha.4

bump

fix cli startup

bumps

fix and run unit tests on ci

default to v2 for alpha release

remove broken merge-token-accounts test from CI (has TODO: not required)

fix: mergeTokenAccounts - process single batch per tx to avoid proof invalidation

The original implementation tried to merge multiple batches in one transaction,
but each batch's validity proof was based on state BEFORE any merges. This caused
proofs to be invalid after the first batch executed.

Fixed by processing only one batch of up to 4 accounts per call. Call repeatedly
until 1 account remains if full consolidation is needed.

feat: mergeTokenAccounts supports up to 8 accounts for V2 (4 for V1)

pass allowOwnerOffCurve along call chain

wip

createLoadAtaInstructions shouldnt err on accountnotfound

add rpc readiness check

fix ixdata and default to right token program on getOrCreateAtaInterface

wip

fix getOrCreateAtaInterface

static 200k cu meter

scope v1 correctly

test

fixes

wip

sequential e2e

bump to alpha.6

fix getstatetreeinfos versioning

bump lockfile

add temp devnet backward compat helpers for mintaction

fix ci test assert for v1 build, and bump pkgs

add test case, create empty ata on load at minimum

hide compat fully

bump v

fix ci

browser spec fix
@SwenSchaeferjohann SwenSchaeferjohann merged commit 89d3cef into main Jan 6, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ananas-block ananas-block ananas-block approved these changes

@sergeytimoshin sergeytimoshin Awaiting requested review from sergeytimoshin sergeytimoshin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SwenSchaeferjohann @ananas-block