FBTweak.xcodeproj: Stop copying header files.#11
Merged
Barak Weiss (barakwei) merged 1 commit intoLightricks:masterfrom Feb 19, 2018
Merged
Conversation
Before this commmit, the project copied header files to the include directory after build, which eliminates the need to add header file paths in projects that use this project. This, however, has some unwanted side-effects, like the include directory not being cleaned when clean is performed, and more subtle bugs that causes new header files not being copied. Futhermore, since we specify header search path for all libraries, the both the original header files and the files manually copied by the project are in the header search path. This may lead to problems when the copy did not happen for some reason.
Michael Kimyagarov (mkimi-lightricks)
approved these changes
Feb 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commmit, the project copied header files to the include
directory after build, which eliminates the need to add header file
paths in projects that use this project. This, however, has some
unwanted side-effects, like the include directory not being cleaned
when clean is performed, and more subtle bugs that causes new header
files not being copied.
Futhermore, since we specify header search path for all libraries, the
both the original header files and the files manually copied by the
project are in the header search path. This may lead to problems when
the copy did not happen for some reason.