Skip to content

Introduce Gap Awarness#107

Merged
georgi-l95 merged 6 commits intomainfrom
minor-improvements
Aug 13, 2025
Merged

Introduce Gap Awarness#107
georgi-l95 merged 6 commits intomainfrom
minor-improvements

Conversation

@georgi-l95
Copy link
Copy Markdown
Contributor

@georgi-l95 georgi-l95 commented Aug 12, 2025

Description

This PR aims to enable Rock Node to start from block number different from 0.
It also tries to bring gap awarness in the project, specifically in the persistance plugin. This way we will always be availbe for the consensus node to stream blocks without worring about behind and too far behind statuses.

Related Issues

Reviewer Checklist

  • The code follows the project's coding standards.
  • New and existing unit tests pass locally with my changes.
  • I have added necessary documentation (if applicable).
  • I have confirmed that this change does not introduce any new security vulnerabilities.

Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 self-assigned this Aug 12, 2025
@georgi-l95 georgi-l95 added plugin: persistence Related to the Persistence Plugin or storage tiers. area: core Related to core application logic, startup, or configuration. labels Aug 12, 2025
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 93.77289% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.80%. Comparing base (ff7c397) to head (9d7c18c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...de-persistence-plugin/src/cold_storage/archiver.rs 85.43% 15 Missing ⚠️
crates/rock-node-persistence-plugin/src/state.rs 93.53% 13 Missing ⚠️
crates/rock-node-persistence-plugin/src/service.rs 94.16% 7 Missing ⚠️
...es/rock-node-state-management-plugin/src/plugin.rs 0.00% 5 Missing ⚠️
...rates/rock-node-persistence-plugin/src/hot_tier.rs 96.29% 3 Missing ⚠️
crates/rock-node-persistence-plugin/src/lib.rs 0.00% 3 Missing ⚠️
app/rock-node/src/main.rs 0.00% 2 Missing ⚠️
...node-persistence-plugin/src/cold_storage/reader.rs 97.50% 1 Missing ⚠️
...node-persistence-plugin/src/cold_storage/writer.rs 97.36% 1 Missing ⚠️
...es/rock-node-publish-plugin/src/session_manager.rs 99.53% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #107       +/-   ##
===========================================
+ Coverage   47.16%   64.80%   +17.64%     
===========================================
  Files          47       47               
  Lines        5710     6444      +734     
===========================================
+ Hits         2693     4176     +1483     
+ Misses       3017     2268      -749     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@georgi-l95 georgi-l95 added this to the 0.2.0 milestone Aug 13, 2025
@georgi-l95 georgi-l95 changed the title accept different start block number Introduce Gap Awarness Aug 13, 2025
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
Signed-off-by: georgi-l95 <glazarov95@gmail.com>
@georgi-l95 georgi-l95 marked this pull request as ready for review August 13, 2025 13:33
@georgi-l95 georgi-l95 merged commit 50fd815 into main Aug 13, 2025
5 checks passed
@georgi-l95 georgi-l95 deleted the minor-improvements branch August 13, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: core Related to core application logic, startup, or configuration. plugin: persistence Related to the Persistence Plugin or storage tiers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Introduce Gap Awarness

1 participant