Skip to content

Implement metadata v15 #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
failfmi merged 37 commits into from
Oct 13, 2023
Merged

Implement metadata v15 #231

failfmi merged 37 commits into from
Oct 13, 2023

Conversation

@nicksinch
Copy link
Contributor

@nicksinch nicksinch commented Oct 11, 2023 •
edited by failfmi
Loading

Detailed description:
Adds support for Metadata V15:

  • Adds new structs required by the v15 spec
  • Adds new metadata types in some of the frame modules as well as in the metadata api
  • Two more runtime functions exported: Metadata_at_version(version) and Metadata_versions()
  • Leaves the default metadata version returned to be 14
  • Adjusts the tests to expect a default metadata version 14

Which issue(s) this PR fixes:
Fixes #192 , #193

Checklist

  • Documentation added
  • Tests updated

@nicksinch nicksinch requested review from failfmi and radkomih October 11, 2023 06:22
@nicksinch nicksinch force-pushed the implement-metadata-v15 branch from a7e88cc to 230a3f7 Compare October 11, 2023 06:58
failfmi
failfmi reviewed Oct 11, 2023
View reviewed changes
failfmi
failfmi reviewed Oct 11, 2023
View reviewed changes
failfmi
failfmi reviewed Oct 11, 2023
View reviewed changes
failfmi
failfmi reviewed Oct 11, 2023
View reviewed changes
This was linked to issues Oct 11, 2023
implement Metadata v15 #192
Closed
implement runtime metadata api - Metadata_metadata_at_version and Metadata_metadata_versions #193
Closed
@nicksinch nicksinch force-pushed the implement-metadata-v15 branch 2 times, most recently from 71f62db to ff0deda Compare October 11, 2023 13:37
failfmi
failfmi requested changes Oct 12, 2023
View reviewed changes
radkomih
radkomih reviewed Oct 12, 2023
View reviewed changes
@nicksinch nicksinch force-pushed the implement-metadata-v15 branch from a89ac68 to 776e40b Compare October 12, 2023 08:10
failfmi
failfmi reviewed Oct 12, 2023
View reviewed changes
failfmi
failfmi reviewed Oct 12, 2023
View reviewed changes
@failfmi failfmi requested a review from radkomih October 12, 2023 08:53
@nicksinch nicksinch force-pushed the implement-metadata-v15 branch from 02ad281 to 39fe712 Compare October 12, 2023 09:09
@failfmi failfmi self-requested a review October 12, 2023 09:11
failfmi
failfmi previously approved these changes Oct 12, 2023
View reviewed changes
radkomih
radkomih previously approved these changes Oct 13, 2023
View reviewed changes
@nicksinch nicksinch force-pushed the implement-metadata-v15 branch from 479126e to 184e6d5 Compare October 13, 2023 06:21
@nicksinch nicksinch force-pushed the implement-metadata-v15 branch from 184e6d5 to 8fd3cce Compare October 13, 2023 07:06
@failfmi failfmi self-requested a review October 13, 2023 07:16
@failfmi failfmi merged commit f1ccc41 into develop Oct 13, 2023
@failfmi failfmi deleted the implement-metadata-v15 branch October 13, 2023 08:02
This was referenced Oct 13, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radkomih radkomih radkomih approved these changes

@failfmi failfmi failfmi approved these changes

Assignees

@nicksinch nicksinch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

implement runtime metadata api - Metadata_metadata_at_version and Metadata_metadata_versions implement Metadata v15

4 participants

@nicksinch @radkomih @failfmi