refactor: move from single market per pmm to multi#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the pr allows us to specify multiple markets of the same prop AMM during swaps. It also introduces versioned swaps so we can specify both protocol version and swap kind, as some amms offer multiple instructions.
with this pr, this is a valid call:
the swap goes through four different humidifi pools and ends with bisonfi's
51FQwjrvo8J8zXUaKyAznJ5NYpoiTCuqAqCu3HAMB9NZ.to explicitly specify which pool a swap should take from the list of defined markets (reference
cfg/setup.toml) - suffix the pmm name with the market's address - or a substring of the address (as we've done in the example above).If no explicit address is specified, we'll default to the first one defined in
cfg/setup.toml.