fix(mcp): use outputFile for custom filenames to respect --output-dir#1
Open
Limitless2023 wants to merge 1 commit intomainfrom
Open
fix(mcp): use outputFile for custom filenames to respect --output-dir#1Limitless2023 wants to merge 1 commit intomainfrom
Limitless2023 wants to merge 1 commit intomainfrom
Conversation
When --output-dir is configured, custom filenames passed to screenshot/pdf/etc. tools were being saved to workspace root instead of --output-dir. This fix ensures both auto-generated and custom filenames use outputFile(), which correctly resolves paths against --output-dir. Closes microsoft/playwright-mcp#1390
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes microsoft/playwright-mcp#1390
When
--output-diris configured, custom filenames passed to screenshot/pdf/etc. tools were being saved to workspace root instead of--output-dir.Root Cause
In
resolveClientFile(), when asuggestedFilenamewas provided, it usedworkspaceFile()which always saves to workspace root. Only auto-generated filenames usedoutputFile()which respects--output-dir.Fix
Changed
resolveClientFile()to always useoutputFile()for both auto-generated and custom filenames. TheoutputFile()method already correctly handlessuggestedFilename- it uses it as the basename and resolves againstoutputDir.Code Change