[PATCH v6] example:ipsec_offload: Adding ipsec_offload example by NikhilA-Linaro · Pull Request #12 · OpenDataPlane/odp

NikhilA-Linaro · 2017-04-10T11:23:34Z

Signed-off-by: Nikhil Agarwal nikhil.agarwal@linaro.org

NikhilA-Linaro · 2017-04-11T12:25:57Z

How do we trigger CI build when pull request is updated? @muvarov

muvarov · 2017-04-11T12:37:50Z

@NikhilA-Linaro should be done automatically

NikhilA-Linaro · 2017-04-11T13:14:30Z

@muvarov but it is not triggered for this pull request

muvarov · 2017-04-11T13:20:09Z

@NikhilA-Linaro yes, I can run it manually https://travis-ci.org/Linaro/odp/builds/220518411 but I do not see why it did not trigger or how to trigger it. There is fails with tap test which I can not reproduce locally but Bill can. So looks like Travis is happy this that log.

muvarov · 2017-04-11T19:37:45Z

@NikhilA-Linaro looks like there was Mikes Travis hash and he remove it just in time when you updated pull request. I set up my hash and hope it will work in future.

muvarov · 2017-04-18T16:24:41Z

@NikhilA-Linaro There was some billing issues with github for Linaro group and Travis and web hooks stopped to work. Now all has to work again. To make your pull request validated I think you have to re create it.

lumag · 2017-04-19T13:45:04Z

@NikhilA-Linaro @muvarov won't just pushing an 'updated' version of the PR be sufficient to trigger CI build?

muvarov · 2017-04-19T13:46:26Z

@NikhilA-Linaro it has to work.

codecov-io · 2017-04-21T07:16:10Z

Codecov Report

Merging #12 into api-next will increase coverage by 0.12%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           api-next       #12      +/-   ##
=============================================
+ Coverage    78.767%   78.887%   +0.12%     
=============================================
  Files           198       198              
  Lines         34018     34018              
=============================================
+ Hits          26795     26836      +41     
+ Misses         7223      7182      -41

Impacted Files	Coverage Δ
test/common_plat/validation/api/timer/timer.c	`79.233% <0%> (+2.236%)`	⬆️
platform/linux-generic/odp_timer_wheel.c	`86.904% <0%> (+8.095%)`	⬆️

NikhilA-Linaro · 2017-04-24T12:00:01Z

@lumag can you please review the same?

lumag · 2017-04-24T12:05:57Z

+				EXAMPLE_DBG("Error Event\n");
+				odp_event_free((odp_event_t)ev);
+				continue;
+			}


According to current API, there should be a call to odp_event_free() here.

My proposal removes need for it if odp_ipsec_result() returns 0.

lumag · 2017-04-24T12:06:15Z

+
+			if (odp_unlikely(odp_ipsec_result(&result, ev) < 0)) {
+				EXAMPLE_DBG("Error Event\n");
+				odp_event_free((odp_event_t)ev);


No need for type cast.

lumag · 2017-04-24T12:07:14Z

+			}
+
+			if (odp_unlikely(res.status.all_error)) {
+				odp_packet_free((odp_packet_t)ev);


odp_packet_free(out_pkt). Event might be something other than a packet.

lumag · 2017-04-24T12:09:47Z

+
+			eth = (odph_ethhdr_t *)((uint8_t *)ip -
+						sizeof(odph_ethhdr_t));
+			eth->dst = out_port->next_hop_addr;


Here you should make sure that there is enough space before l3 offset. Also you should push that data in front of the packet.

Bill-Fischofer-Linaro · 2017-05-05T20:36:40Z

+}
+
+/**
+ * IPsec pre argument processing intialization


Typo: initialization

Bill-Fischofer-Linaro · 2017-05-05T20:37:07Z

+}
+
+/**
+ * IPsec post argument processing intialization


Typo: initialization

Bill-Fischofer-Linaro · 2017-05-05T20:39:08Z

+ */
+#define DEFAULT_BUCKET_COUNT	1024
+
+/**< Number of bits represnted by a string of hexadecimal characters */


Typo: represented

lumag · 2017-05-22T07:34:47Z

@NikhilA-Linaro could you please do final changes accroding to the review? Let's finally get this merged.

muvarov · 2017-06-16T19:48:02Z

Ping. Changes are needed according to comments.

muvarov · 2017-08-04T17:03:47Z

Please update and rebase patches.

Bill-Fischofer-Linaro · 2017-08-23T20:24:12Z

Ping to @NikhilA-Linaro. PR needs to be rebased before it can be merged.

Bill-Fischofer-Linaro · 2017-09-22T14:21:59Z

@NikhilA-Linaro You were going to update this PR to rebase it as well as to illustrate how your proposed change to the definition of odp_ipsec_sa_disable() should work from an application standpoint. Please do so. Thanks.

muvarov added the Email_sent label Apr 10, 2017

NikhilA-Linaro force-pushed the api-next branch 3 times, most recently from a9d7a03 to 8714878 Compare April 11, 2017 06:38

muvarov added the Email_sent label Apr 11, 2017

NikhilA-Linaro force-pushed the api-next branch from 8714878 to 1a8c9c5 Compare April 21, 2017 06:52

lumag reviewed Apr 24, 2017

View reviewed changes

Bill-Fischofer-Linaro reviewed May 5, 2017

View reviewed changes

NikhilA-Linaro force-pushed the api-next branch from 1a8c9c5 to 90e1101 Compare July 13, 2017 06:26

muvarov changed the title ~~example:ipsec_offload: Adding ipsec_offload example~~ [PATCH API-NEXT v1] example:ipsec_offload: Adding ipsec_offload example Jul 13, 2017

muvarov added Email_sent and removed Email_sent labels Jul 13, 2017

muvarov self-requested a review August 4, 2017 17:03

muvarov added the checkpatch label Aug 11, 2017

NikhilA-Linaro force-pushed the api-next branch from 90e1101 to d476e19 Compare October 10, 2017 10:15

muvarov changed the title ~~[PATCH API-NEXT v1] example:ipsec_offload: Adding ipsec_offload example~~ [PATCH API-NEXT v2] example:ipsec_offload: Adding ipsec_offload example Oct 10, 2017

muvarov removed Email_sent labels Oct 10, 2017

NikhilA-Linaro closed this Oct 10, 2017

NikhilA-Linaro force-pushed the api-next branch from d476e19 to 0955fbb Compare October 10, 2017 10:17

muvarov changed the title ~~[PATCH API-NEXT v2] example:ipsec_offload: Adding ipsec_offload example~~ [PATCH API-NEXT v3] example:ipsec_offload: Adding ipsec_offload example Oct 10, 2017

MatiasElo changed the title ~~[PATCH API-NEXT v3] example:ipsec_offload: Adding ipsec_offload example~~ [PATCH v4] example:ipsec_offload: Adding ipsec_offload example Oct 14, 2020

MatiasElo changed the title ~~[PATCH v4] example:ipsec_offload: Adding ipsec_offload example~~ [PATCH v5] example:ipsec_offload: Adding ipsec_offload example Oct 15, 2020

MatiasElo changed the title ~~[PATCH v5] example:ipsec_offload: Adding ipsec_offload example~~ [PATCH v6] example:ipsec_offload: Adding ipsec_offload example Oct 15, 2020

Conversation

NikhilA-Linaro commented Apr 10, 2017

Uh oh!

NikhilA-Linaro commented Apr 11, 2017

Uh oh!

muvarov commented Apr 11, 2017

Uh oh!

NikhilA-Linaro commented Apr 11, 2017

Uh oh!

muvarov commented Apr 11, 2017

Uh oh!

muvarov commented Apr 11, 2017

Uh oh!

muvarov commented Apr 18, 2017

Uh oh!

lumag commented Apr 19, 2017

Uh oh!

muvarov commented Apr 19, 2017

Uh oh!

codecov-io commented Apr 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

NikhilA-Linaro commented Apr 24, 2017

Uh oh!

lumag Apr 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lumag Apr 24, 2017

Choose a reason for hiding this comment

Uh oh!

lumag Apr 24, 2017

Choose a reason for hiding this comment

Uh oh!

lumag Apr 24, 2017

Choose a reason for hiding this comment

Uh oh!

Bill-Fischofer-Linaro May 5, 2017

Choose a reason for hiding this comment

Uh oh!

Bill-Fischofer-Linaro May 5, 2017

Choose a reason for hiding this comment

Uh oh!

Bill-Fischofer-Linaro May 5, 2017

Choose a reason for hiding this comment

Uh oh!

lumag commented May 22, 2017

Uh oh!

muvarov commented Jun 16, 2017

Uh oh!

muvarov commented Aug 4, 2017

Uh oh!

Bill-Fischofer-Linaro commented Aug 23, 2017

Uh oh!

Bill-Fischofer-Linaro commented Sep 22, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov-io commented Apr 21, 2017 •

edited

Loading

lumag Apr 24, 2017 •

edited

Loading