[PATCH API-NEXT v1] api: ipsec: more capabilities

[lumag]

• Add AH support capability (as AH is optional in RFC 4301).
• Split INLINE capability into pair of in and out caps.

[codecov-io]

Codecov Report

Merging #26 into api-next will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           api-next     #26      +/-   ##
===========================================
+ Coverage     78.72%   78.8%   +0.07%     
===========================================
  Files           189     189              
  Lines         33329   33329              
===========================================
+ Hits          26239   26264      +25     
+ Misses         7090    7065      -25

Impacted Files	Coverage Δ
test/linux-generic/pktio_ipc/ipc_common.c	72.13% <0%> (-3.28%)	⬇️
platform/linux-generic/pktio/ipc.c	76.03% <0%> (-0.96%)	⬇️
platform/linux-generic/_ishm.c	73.51% <0%> (-0.92%)	⬇️
test/linux-generic/pktio_ipc/pktio_ipc2.c	66.66% <0%> (-0.86%)	⬇️
test/linux-generic/pktio_ipc/pktio_ipc1.c	70.94% <0%> (-0.56%)	⬇️
helper/test/cuckootable.c	81.47% <0%> (+0.54%)	⬆️
platform/linux-generic/odp_timer_wheel.c	86.9% <0%> (+8.57%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ea9c1d...5518256. Read the comment docs.

[muvarov]

From: Bala Manoharan 
 Reviewed-by: Balasubramanian Manoharan 

On 10 May 2017 at 12:00, Github ODP bot  wrote:
> From: Dmitry Eremin-Solenikov 
>
> RFC4301 marks AH support as MAY instead of MUST. Some platforms might
> skip implementing AH. Thus we should provide capability to allow
> applications to check if AH is actually implemented or not.
>
> Signed-off-by: Dmitry Eremin-Solenikov 
> ---
> /** Email created from pull request 26 (lumag:ipsec-ah-cap)
>  ** https://github.com/Linaro/odp/pull/26
>  ** Patch: https://github.com/Linaro/odp/pull/26.patch
>  ** Base sha: 3ea9c1dac34e0fb4785b0d643056c731daa55e85
>  ** Merge commit sha: 1b298f0560ad52ebe47022df83bc185cb4a0e11d
>  **/
>  include/odp/api/spec/ipsec.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h
> index e83494d..016d232 100644
> --- a/include/odp/api/spec/ipsec.h
> +++ b/include/odp/api/spec/ipsec.h
> @@ -244,6 +244,9 @@ typedef struct odp_ipsec_capability_t {
>         /** Inline IPSEC operation mode (ODP_IPSEC_OP_MODE_INLINE) support */
>         odp_support_t op_mode_inline;
>
> +       /** Synchronous of AH (ODP_IPSEC_AH ) support */
> +       odp_support_t op_proto_ah;
> +
>         /**
>          * Support of pipelined classification (ODP_IPSEC_PIPELINE_CLS) of
>          *  resulting inbound packets
>
 

[muvarov]

From: "Savolainen, Petri (Nokia - FI/Espoo)" 
 

> -----Original Message-----
> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of
> Github ODP bot
> Sent: Wednesday, May 10, 2017 10:00 PM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH API-NEXT v1 1/1] api: ipsec: add AH capability
> 
> From: Dmitry Eremin-Solenikov 
> 
> RFC4301 marks AH support as MAY instead of MUST. Some platforms might
> skip implementing AH. Thus we should provide capability to allow
> applications to check if AH is actually implemented or not.
> 
> Signed-off-by: Dmitry Eremin-Solenikov 
> ---
> /** Email created from pull request 26 (lumag:ipsec-ah-cap)
>  ** https://github.com/Linaro/odp/pull/26
>  ** Patch: https://github.com/Linaro/odp/pull/26.patch
>  ** Base sha: 3ea9c1dac34e0fb4785b0d643056c731daa55e85
>  ** Merge commit sha: 1b298f0560ad52ebe47022df83bc185cb4a0e11d
>  **/
>  include/odp/api/spec/ipsec.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h
> index e83494d..016d232 100644
> --- a/include/odp/api/spec/ipsec.h
> +++ b/include/odp/api/spec/ipsec.h
> @@ -244,6 +244,9 @@ typedef struct odp_ipsec_capability_t {
>  	/** Inline IPSEC operation mode (ODP_IPSEC_OP_MODE_INLINE)
> support */
>  	odp_support_t op_mode_inline;
> 
> +	/** Synchronous of AH (ODP_IPSEC_AH ) support */

There's couple of copy-paste errors on these two line.

Only this: "AH protocol (ODP_IPSEC_AH) support"

> +	odp_support_t op_proto_ah;

Variable name should be just "proto_ah"

-Petri


> +
>  	/**
>  	 * Support of pipelined classification (ODP_IPSEC_PIPELINE_CLS)
> of
>  	 *  resulting inbound packets

 

[muvarov]

From: "Savolainen, Petri (Nokia - FI/Espoo)" 
 Entire patch set:

Reviewed-by: Petri Savolainen 

> -----Original Message-----
> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of
> Github ODP bot
> Sent: Thursday, May 11, 2017 12:00 AM
> To: lng-odp@lists.linaro.org
> Subject: [lng-odp] [PATCH API-NEXT v1 0/2] api: ipsec: more capabilities
> 
> Add AH support capability (as AH is optional in RFC 4301).
> Split INLINE capability into pair of in and out caps.
> 
> ----------------github------------------------
> /** Email created from pull request 26 (lumag:ipsec-ah-cap)
>  ** https://github.com/Linaro/odp/pull/26
>  ** Patch: https://github.com/Linaro/odp/pull/26.patch
>  ** Base sha: 3ea9c1dac34e0fb4785b0d643056c731daa55e85
>  ** Merge commit sha: 6eb5ba103d81883b2b55945c58214b903bfac64d
>  **/
> ----------------/github------------------------
> 
> ----------------checkpatch.pl------------------------
> total: 0 errors, 0 warnings, 0 checks, 9 lines checked
> 
> 
> to_send-p-000.patch has no obvious style problems and is ready for
> submission.
> total: 0 errors, 0 warnings, 0 checks, 19 lines checked
> 
> 
> to_send-p-001.patch has no obvious style problems and is ready for
> submission.
> ----------------/checkpatch.pl------------------------
 

[muvarov]

Merged.