[PATCH CATERPILLAR v3] pktio: honor config.h settings#394
Closed
joseppc wants to merge 1 commit intoOpenDataPlane:caterpillarfrom
Closed
[PATCH CATERPILLAR v3] pktio: honor config.h settings#394joseppc wants to merge 1 commit intoOpenDataPlane:caterpillarfrom
joseppc wants to merge 1 commit intoOpenDataPlane:caterpillarfrom
Conversation
muvarov
changed the title
heyi-arm
approved these changes
Jan 18, 2018
|
@Bill-Fischofer-Linaro do you like to have a review on this PR? |
Bill-Fischofer-Linaro
approved these changes
Jan 18, 2018
Contributor
Bill-Fischofer-Linaro
left a comment
Bill-Fischofer-Linaro
left a comment
There was a problem hiding this comment.
Reviewed-by: Bill Fischofer bill.fischofer@linaro.org
|
@joseppc this PR needs rebase after Mykyta's driver PRs. |
joseppc
force-pushed
the
check-macro-value
branch
from
f9ec5d7 to
2a4ffb9
Compare
muvarov
changed the title
Author
|
I rebased the PR and updated mdev pktio files too. |
|
@joseppc sorry Josep after I merged Mykyta's Chelsio driver this PR needs a rebase again, sorry about this inconvenience can you rebase again and I'll merge it right after. |
It's not enough to chech if a macro is defined to enable or disable a pktio, we also need to check if it is set to 1 to match the description in config.h Signed-off-by: Josep Puigdemont <josep.puigdemont@linaro.org>
joseppc
force-pushed
the
check-macro-value
branch
from
2a4ffb9 to
5967c6e
Compare
muvarov
changed the title
Author
|
Rebased. |
|
Great, merged and closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not enough to chech if a macro is defined to enable or disable a
pktio, we also need to check if it is set to 1 as per its description.
Signed-off-by: Josep Puigdemont josep.puigdemont@linaro.org