Skip to content

Feature/GitHub actions frontend#9

Open
LindaBot wants to merge 8 commits intomainfrom
feature/githubActionsFrontend
Open

Feature/GitHub actions frontend#9
LindaBot wants to merge 8 commits intomainfrom
feature/githubActionsFrontend

Conversation

@LindaBot
Copy link
Copy Markdown
Owner

@LindaBot LindaBot commented Mar 17, 2021

Description

This PR fixes #[Insert Issue Number]

Please include a summary of the changes here.

Demo

(Please include screenshots/GIF here if applicable)

Before: [Insert Screenshot]

After: [Insert Screenshot]

Type of change:

(Delete the ones that are not relevant)

  • New feature (Non-breaking change that adds functionality)
  • Bug fix (Non-breaking change which fixes a bug)
  • Breaking change (This change would cause existing functionality to break)
  • This change requires a documentation update - Documentation issue number #[Insert Issue Number]

Checklist:

  • Have you merged main into your branch?
  • Have you tested your changes to ensure it works as expected and does not break existing functionality?
  • If applicable, please ensure sufficient tests are added that is related to the changes.
  • Please ensure this PR has a label, is linked to an issue and is related to a project
  • If new documentation is required for this change, have you created a new documentation issue that describes the documentation needed?

ateagit and others added 5 commits March 17, 2021 15:01
@ateagit
Created socket client to communicate with backend. (Mafia-Hands#141)
51dcc1c 
* Started on game state

* continued working on state

* improving socket io state

* fixed detective

* moved logic to hook

* added another hook and clean up

* removed unused import

* added fixes for fe

* removed comments

* fixed errors from rebase

* fixed PR comments
@LindaBot
Remove .DS_Store
71b32d7
@LindaBot
Remove root level package-lock.json
ab76841
@LindaBot
Add frontend testing and test with a warning
fa9e6e5
@LindaBot
Remove warning for testing CI
cb164f5
@LindaBot LindaBot mentioned this pull request Mar 17, 2021
Merged
LindaBot added 3 commits March 17, 2021 20:52
@LindaBot
Fix lobby bugs identified during integration (Mafia-Hands#146)
30b1ecd 
* Remove the redundant `start-game` event and return find the correct player in lobby-ready event - Mafia-Hands#140, Mafia-Hands#144

* Fix host not receiving roles

* Fix the number of civilians to be returned

* Reverse package-lock.json cause there's isn't any frontend change
@LindaBot
Do nothing if a lobby doesn't exist (Mafia-Hands#152)
f546a69 
Handle user trying to join non-existent lobby
@LindaBot
Merge branch 'main' into feature/githubActionsFrontend
53037c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LindaBot @ateagit