Skip to content

Comments

LIN-579 Provide user with pipeline test skeleton#772

Merged
yoonspark merged 15 commits intomainfrom
LIN-579-provide-user-with-pipeline-test-skeleton
Oct 3, 2022
Merged

LIN-579 Provide user with pipeline test skeleton#772
yoonspark merged 15 commits intomainfrom
LIN-579-provide-user-with-pipeline-test-skeleton

Conversation

@yoonspark
Copy link
Contributor

@yoonspark yoonspark commented Sep 13, 2022

Summary

As a first story of the Enable Pipeline Testing epic, this PR implements a bare minimal scaffolding for pipeline testing, where:

  • Each function in the module gets a corresponding test case
  • Each test case simply calls the tested function within a try-catch block
  • Comments are provided to instruct the user to adjust test logic as needed

Though very simple, this bare minimal templating may still deliver some value to the user as it provides them a starting point for pipeline testing (better to have something than nothing). Again, this is a first story for the epic, and the plan is to improve on it with subsequent stories.

Changes

  • Add a new Jinja template for rudimentary scaffolding of pipeline testing
  • Add a new (hidden) method to BasePipelineWriter to fill in the Jinja template
  • Add new unit tests for the pipeline test scaffolding

Testing

Unit tests were added to cover the new functionality.

Ticket(s)

@yoonspark yoonspark marked this pull request as draft September 13, 2022 20:11
@yoonspark yoonspark marked this pull request as ready for review September 13, 2022 22:16
@mingjerli mingjerli self-requested a review September 14, 2022 14:44
@yoonspark yoonspark force-pushed the LIN-579-provide-user-with-pipeline-test-skeleton branch 3 times, most recently from 2873297 to 82f79a3 Compare September 30, 2022 23:44
@yoonspark yoonspark force-pushed the LIN-579-provide-user-with-pipeline-test-skeleton branch from 82f79a3 to 590335b Compare October 3, 2022 19:28
@yoonspark yoonspark requested a review from lionsardesai October 3, 2022 20:07
Copy link
Contributor

@lionsardesai lionsardesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. comments made are not show stoppers. can also be done in subsequent stories.

@yoonspark yoonspark merged commit d43fb44 into main Oct 3, 2022
@yoonspark yoonspark deleted the LIN-579-provide-user-with-pipeline-test-skeleton branch October 3, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants