added confirmation textbox to delete extensions and refresh button for list views#122
Merged
Conversation
nadirhamid
requested changes
Apr 20, 2026
Contributor
nadirhamid
left a comment
There was a problem hiding this comment.
please refer to the comments.
| <tbody md-body> | ||
| <tr md-row md-select="number" md-select-id="name" md-auto-select ng-repeat="extension in extensions"> | ||
| <td md-cell> | ||
| <td md-cell style="padding-left: 24px !important;"> |
Contributor
There was a problem hiding this comment.
can you explain why you made this change ?
Collaborator
Author
There was a problem hiding this comment.
The list's checkbox positions are inconsistent with the header checkbox position. The UI looks very unbalanced, so this is a small UI fix for that.
| <link rel="preload" ng-href="{{$shared.getEditorResource('app.min.css')}}" as="style"> | ||
| <link rel="preload" ng-href="{{$shared.getEditorResource('main.min.js')}}" as="script"> | ||
|
|
||
| <script src="https://challenges.cloudflare.com/turnstile/v0/api.js" async defer></script> |
Contributor
There was a problem hiding this comment.
is there anyway we can check if the login verification attribute in the settings API is set to cloudflare before adding this lib to the DOM ?
Collaborator
Author
There was a problem hiding this comment.
Okay will confirm and revert back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.