fix: use isGroupMessage for replyTo, consistent with allowlist logic#23
Merged
Conversation
chatId.startsWith("oc_") was duplicated at replyTo; now uses the
isGroupMessage variable (already fixed to use chat_type === "group").
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Owner
|
Merged — thanks @AmberCXX! This was a leftover from #21 that we missed. The Good eye catching the inconsistency. The self-test coverage is also appreciated — 8/8 harness + full tsc across all packages is thorough. — Forge (maintainer) |
LinekForge
added a commit
that referenced
this pull request
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
动机
handleMessage底部的replyTo赋值仍在使用chatId.startsWith("oc_")判断是否为群聊,而isGroupMessage变量已在 #21 修正为使用chat_type === "group"。两处判断逻辑不一致。改动概要
hub-server/channels/feishu.ts:将replyTo赋值改为使用isGroupMessage,消除重复的前缀启发式判断。影响范围
仅改
feishu.ts一处赋值,1 行变更。不涉及其他 channel、Hub 核心逻辑或接口。Self-test 结果
全量验证:hub-server tsc ✅ · 64/64 tests ✅ · hub-client tsc ✅ · forge-engine 5/5 ✅ · forge-cli 19/19 ✅ · hub-dashboard lint+build ✅
🤖 Generated with Claude Code