chore: remove unused backfill scripts (SIT-302)#33
Merged
Conversation
These one-time backfill scripts were dead weight: undocumented, so no operator would run them, and unnecessary — retention already deletes click_events/install_events (and the rollup) per tier, so un-flagged legacy rows age out on their own. The bot backfill was also incomplete (it left already-built rollups stale). Steady state is correct without them: new clicks are classified at ingestion. Removes src/scripts/backfill-bot-flags.ts, src/scripts/backfill-attribution.ts, and their npm script entries. isbot stays (used by the live classifier).
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the two one-time backfill scripts and their npm entries:
src/scripts/backfill-bot-flags.tssrc/scripts/backfill-attribution.tsWhy
They're dead weight:
cleanupOldAnalytics) already prunesclick_events/install_events(and the rollup) per tier, so un-flagged legacy rows age out on their own within a retention window.backfill:bot-flagswas also incomplete — it fixed rawclick_eventsbut left already-built rollup days stale, so it never fully worked anyway.Steady state is correct without them: new clicks are classified at ingestion (
lib/bot-detection.ts).isbotis retained (used by the live classifier). Also updated one stale comment indatabase.tsthat referenced the removed backfill.Typecheck clean; no residual references.