Conversation
khider
reviewed
Apr 21, 2026
|
|
||
| ### Data Provider: | ||
|
|
||
| In PyleoTUPS, a "Data Provider" is a backend paleoclimate repository that: |
Member
There was a problem hiding this comment.
Not sure many scientists will know "backend" in this context.
khider
reviewed
Apr 21, 2026
| PANGAEA organizes datasets differently than NOAA: | ||
|
|
||
| ``` | ||
| Dataset (standalone publication) |
Member
There was a problem hiding this comment.
instead of the NOAA diagram, it might make more sense to explain NOAA as you did PANGAEA here.
khider
reviewed
Apr 21, 2026
| Unlike NOAA, one Pangaea Dataset contains only one Data Table i.e. 1 csv/tsv type file. | ||
| ``` | ||
| ### PANGAEA Query Interface | ||
|
|
Member
There was a problem hiding this comment.
you want to explain what a faceted search is for paleoclimate scientists
khider
reviewed
Apr 21, 2026
| --- | ||
|
|
||
| ## Next Steps | ||
|
|
Member
There was a problem hiding this comment.
next step: can you link? Also this is part of the tutorials, so maybe we will need to refer to section 2 later on but would be a good idea to say next section for now. Instead of API reference, just say documentation with a link to readthedocs for complete parameter explanation
khider
requested changes
Apr 21, 2026
Member
khider
left a comment
khider
left a comment
There was a problem hiding this comment.
- Pull the noaa_ER_diagram in a figure folder (it won't be the only one and it will make the repo a bit cleaner) - if still needed. I like the style used for PANGAEA
- Look at the comments.
khider
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown documentation about :