Skip to content
This repository was archived by the owner on Feb 17, 2021. It is now read-only.

Fixed Swift ObjC Wrapper of layout#212

Merged
staguer merged 3 commits intomasterfrom
objcWrapperFix
May 31, 2018
Merged

Fixed Swift ObjC Wrapper of layout#212
staguer merged 3 commits intomasterfrom
objcWrapperFix

Conversation

@drumnkyle
Copy link
Copy Markdown
Collaborator

There could be an issue if you inherit from one of the provided layouts from LayoutKit. This fix makes it so that if you do that, it will call the correct overridden methods.

There could be an issue if you inherit from one of the provided layouts from LayoutKit. This fix makes it so that if you do that, it will call the correct overridden methods.
@drumnkyle drumnkyle requested a review from staguer May 30, 2018 00:29
LOKStackLayout.self,
LOKTextViewLayout.self
]
if let object = self as? NSObject {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment explaining why we need to do this

@staguer staguer merged commit 85d9a51 into master May 31, 2018
@staguer staguer deleted the objcWrapperFix branch October 25, 2018 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants